* [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
@ 2021-04-04 12:46 Dinh Nguyen
2021-04-04 14:08 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Dinh Nguyen @ 2021-04-04 12:46 UTC (permalink / raw)
To: gregkh
Cc: dinguyen, linux-kernel, Krzysztof Kozlowski, kernel test robot,
Richard Gong
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
The Stratix10 service layer and RCU drivers are useful only on
Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM
fails:
drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback':
include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179'
declared with attribute error: FIELD_GET: type of reg too small for mask
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
...
drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET'
priv->status.version = FIELD_GET(RSU_VERSION_MASK,
Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Richard Gong <richard.gong@linux.intel.com>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
v2: add Fixes tag
---
drivers/firmware/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 6a4e882e448d..08bd4d01fb04 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -206,7 +206,7 @@ config FW_CFG_SYSFS_CMDLINE
config INTEL_STRATIX10_SERVICE
tristate "Intel Stratix10 Service Layer"
- depends on ARCH_INTEL_SOCFPGA && HAVE_ARM_SMCCC
+ depends on ARCH_INTEL_SOCFPGA && ARM64 && HAVE_ARM_SMCCC
default n
help
Intel Stratix10 service layer runs at privileged exception level,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
2021-04-04 12:46 [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM Dinh Nguyen
@ 2021-04-04 14:08 ` Greg KH
2021-04-04 15:20 ` Dinh Nguyen
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-04-04 14:08 UTC (permalink / raw)
To: Dinh Nguyen
Cc: linux-kernel, Krzysztof Kozlowski, kernel test robot, Richard Gong
On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> The Stratix10 service layer and RCU drivers are useful only on
> Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM
> fails:
>
> drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback':
> include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179'
> declared with attribute error: FIELD_GET: type of reg too small for mask
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> ...
> drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET'
> priv->status.version = FIELD_GET(RSU_VERSION_MASK,
>
> Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA")
Where is this commit id? I don't see it in Linus's tree, is it
somewhere else?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
2021-04-04 14:08 ` Greg KH
@ 2021-04-04 15:20 ` Dinh Nguyen
2021-04-05 10:30 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Dinh Nguyen @ 2021-04-04 15:20 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, Krzysztof Kozlowski, kernel test robot, Richard Gong
On 4/4/21 9:08 AM, Greg KH wrote:
> On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>
>> The Stratix10 service layer and RCU drivers are useful only on
>> Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM
>> fails:
>>
>> drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback':
>> include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179'
>> declared with attribute error: FIELD_GET: type of reg too small for mask
>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>> ...
>> drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET'
>> priv->status.version = FIELD_GET(RSU_VERSION_MASK,
>>
>> Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA")
>
> Where is this commit id? I don't see it in Linus's tree, is it
> somewhere else?
>
It's in the for-next branch in the soc tree. This patch fixes a patch
that was just recently submitted by Krzysztof.
Dinh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
2021-04-04 15:20 ` Dinh Nguyen
@ 2021-04-05 10:30 ` Greg KH
2021-04-05 13:09 ` Dinh Nguyen
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-04-05 10:30 UTC (permalink / raw)
To: Dinh Nguyen
Cc: linux-kernel, Krzysztof Kozlowski, kernel test robot, Richard Gong
On Sun, Apr 04, 2021 at 10:20:26AM -0500, Dinh Nguyen wrote:
>
>
> On 4/4/21 9:08 AM, Greg KH wrote:
> > On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote:
> > > From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > >
> > > The Stratix10 service layer and RCU drivers are useful only on
> > > Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM
> > > fails:
> > >
> > > drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback':
> > > include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179'
> > > declared with attribute error: FIELD_GET: type of reg too small for mask
> > > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > > ...
> > > drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET'
> > > priv->status.version = FIELD_GET(RSU_VERSION_MASK,
> > >
> > > Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA")
> >
> > Where is this commit id? I don't see it in Linus's tree, is it
> > somewhere else?
> >
>
> It's in the for-next branch in the soc tree. This patch fixes a patch that
> was just recently submitted by Krzysztof.
Then it needs to go through that tree, while you sent it "To:" me, and I
can't do anything with it at the moment :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM
2021-04-05 10:30 ` Greg KH
@ 2021-04-05 13:09 ` Dinh Nguyen
0 siblings, 0 replies; 5+ messages in thread
From: Dinh Nguyen @ 2021-04-05 13:09 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, Krzysztof Kozlowski, kernel test robot, Richard Gong
On 4/5/21 5:30 AM, Greg KH wrote:
> On Sun, Apr 04, 2021 at 10:20:26AM -0500, Dinh Nguyen wrote:
>>
>>
>> On 4/4/21 9:08 AM, Greg KH wrote:
>>> On Sun, Apr 04, 2021 at 07:46:09AM -0500, Dinh Nguyen wrote:
>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>>
>>>> The Stratix10 service layer and RCU drivers are useful only on
>>>> Stratix10, so on ARMv8. Compile testing the RCU driver on 32-bit ARM
>>>> fails:
>>>>
>>>> drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback':
>>>> include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179'
>>>> declared with attribute error: FIELD_GET: type of reg too small for mask
>>>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>>> ...
>>>> drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET'
>>>> priv->status.version = FIELD_GET(RSU_VERSION_MASK,
>>>>
>>>> Fixes: 4483397b0353 ("ARM: socfpga: drop ARCH_SOCFPGA")
>>>
>>> Where is this commit id? I don't see it in Linus's tree, is it
>>> somewhere else?
>>>
>>
>> It's in the for-next branch in the soc tree. This patch fixes a patch that
>> was just recently submitted by Krzysztof.
>
> Then it needs to go through that tree, while you sent it "To:" me, and I
> can't do anything with it at the moment :(
>
Ah okay, got it, thanks!
Dinh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-05 13:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-04 12:46 [PATCHv2 RESEND] firmware: stratix10-svc: build only on 64-bit ARM Dinh Nguyen
2021-04-04 14:08 ` Greg KH
2021-04-04 15:20 ` Dinh Nguyen
2021-04-05 10:30 ` Greg KH
2021-04-05 13:09 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).