From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01039C43461 for ; Mon, 5 Apr 2021 13:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C63A9613A5 for ; Mon, 5 Apr 2021 13:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237378AbhDENNM (ORCPT ); Mon, 5 Apr 2021 09:13:12 -0400 Received: from mga05.intel.com ([192.55.52.43]:9550 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232702AbhDENNK (ORCPT ); Mon, 5 Apr 2021 09:13:10 -0400 IronPort-SDR: uTSk5KZqzzdGpbaH5iVCpnMZUGVjWatMGMUHp9r6rDi8Of2YAXBteUyAgXheOc9Iy0yvxsF8tV i7mDkyBcUMig== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="278087612" X-IronPort-AV: E=Sophos;i="5.81,306,1610438400"; d="scan'208";a="278087612" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 06:12:50 -0700 IronPort-SDR: IRrSVaQqj7Y4poiz5fiR5lOGGx9AZ3RxXUleicj6H25AbiCXfdd7uJQuHrOAo4YERoI2FAnwp4 1nSoaJsNGMHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,306,1610438400"; d="scan'208";a="378965481" Received: from lkp-server01.sh.intel.com (HELO 69d8fcc516b7) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 05 Apr 2021 06:12:47 -0700 Received: from kbuild by 69d8fcc516b7 with local (Exim 4.92) (envelope-from ) id 1lTP26-000A8c-QR; Mon, 05 Apr 2021 13:12:46 +0000 Date: Mon, 5 Apr 2021 21:12:23 +0800 From: kernel test robot To: Loic Poulain , gregkh@linuxfoundation.org, kuba@kernel.org, davem@davemloft.net Cc: kbuild-all@lists.01.org, linux-arm-msm@vger.kernel.org, aleksander@aleksander.es, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bjorn.andersson@linaro.org, manivannan.sadhasivam@linaro.org, Loic Poulain Subject: [PATCH] net: fix odd_ptr_err.cocci warnings Message-ID: <20210405131223.GA21985@2ab4936ad957> References: <1617616369-27305-2-git-send-email-loic.poulain@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617616369-27305-2-git-send-email-loic.poulain@linaro.org> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/net/wwan/mhi_wwan_ctrl.c:239:5-11: inconsistent IS_ERR and PTR_ERR on line 241. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Loic Poulain Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Loic-Poulain/net-Add-a-WWAN-subsystem/20210405-174547 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7d42e84eb99daf9b7feef37e8f2ea1eaf975346b mhi_wwan_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wwan/mhi_wwan_ctrl.c +++ b/drivers/net/wwan/mhi_wwan_ctrl.c @@ -238,7 +238,7 @@ static int mhi_wwan_ctrl_probe(struct mh &wwan_pops, mhiwwan); if (IS_ERR(mhiwwan->wwan_port)) { kfree(mhiwwan); - return PTR_ERR(port); + return PTR_ERR(mhiwwan->wwan_port); } mhiwwan->wwan_port = port;