linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Ricardo Rivera-Matos <r-rivera-matos@ti.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: bq25980: Move props from battery node
Date: Mon, 5 Apr 2021 18:11:09 +0200	[thread overview]
Message-ID: <20210405161109.b7ku52y6hg7lgulw@earth.universe> (raw)
In-Reply-To: <20210211073807.sh6uwv3dt3eqxyy7@kozik-lap>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Hi,

On Thu, Feb 11, 2021 at 08:38:07AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Feb 10, 2021 at 04:56:46PM -0600, Ricardo Rivera-Matos wrote:
> > Currently POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT and
> > POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE are exposed on the battery node
> > and this is incorrect.
> > 
> > This patch exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT and
> > POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE on the charger node rather
> > than the battery node.
> 
> Now it makes sense if you only formatted it in human-readable way.
> Please fix your git/editor/email client/desktop unless you used such
> formatting intentionally. If it was intentional, then please don't - do
> like everyone else in Linux kernel (git log will help).

Thanks, queued to the power-supply tree (I fixed up the broken
commit message).

-- Sebastian

> 
> Best regards,
> Krzysztof
> 
> > 
> > Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family")
> > Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
> > ---
> >  drivers/power/supply/bq25980_charger.c | 40 ++++++++------------------
> >  1 file changed, 12 insertions(+), 28 deletions(-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-04-05 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 22:56 [PATCH v2 1/2] power: supply: bq25980 Apply datasheet revision changes Ricardo Rivera-Matos
2021-02-10 22:56 ` [PATCH v2 2/2] power: supply: bq25980: Move props from battery node Ricardo Rivera-Matos
2021-02-11  7:38   ` Krzysztof Kozlowski
2021-04-05 16:11     ` Sebastian Reichel [this message]
2021-02-11  7:36 ` [PATCH v2 1/2] power: supply: bq25980 Apply datasheet revision changes Krzysztof Kozlowski
2021-04-05 16:09   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210405161109.b7ku52y6hg7lgulw@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=r-rivera-matos@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).