Re: [PATCH 00/18] Rid W=1 warnings from GFS2

[Lee Jones <lee.jones@linaro.org>]

On Tue, 06 Apr 2021, Bob Peterson wrote:

> ----- Original Message -----
> > On Fri, 26 Mar 2021, Lee Jones wrote:
> > 
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > > 
> > > Lee Jones (18):
> > >   fs: gfs2: dir: Finish off mostly complete headers demote others
> > >   fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant
> > >     ones
> > >   fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others
> > >   fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote
> > >     others
> > >   fs: gfs2: log: Fix a couple of param descriptions and demote
> > >     non-conformant headers
> > >   fs: gfs2: lops: Help out worthy kernel-doc headers and demote others
> > >   fs: gfs2: glock: Fix some deficient kernel-doc headers and demote
> > >     non-conformant ones
> > >   fs: gfs2: aops: Fix a little potential doc-rot
> > >   fs: gfs2: meta_io: Add missing description for 'rahead' param
> > >   fs: gfs2: inode: Fix worthy function headers demote others
> > >   fs: gfs2: file: Strip out superflouous param description and demote
> > >     kernel-doc abuse
> > >   fs: gfs2: ops_fstype: Fix a little doc-rot
> > >   fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad'
> > >   fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours
> > >   fs: gfs2: recovery: Provide missing param descriptions and remove one
> > >     other
> > >   fs: gfs2: super: Fix kernel-doc issues where feasible demote one other
> > >   fs: gfs2: util: Fix one conformant kernel-doc header and demote a
> > >     bunch of abuses
> > >   fs: gfs2: lock_dlm: Demote incomplete kernel-doc header
> > 
> > These have been on the list for a couple of weeks now.
> >   
> > Is there anything I can do to help expedite their merge?
> >   
> > I'm concerned since -rc6 has just been released.
> 
> Hi Lee,
> 
> Thanks for your patches. Andreas and I have a slight disagreement about them.
> I wanted to merge them, but Andreas is concerned that there may be some
> cases in which we should get rid of parameter descriptions altogether.
> So I've been waiting for Andreas to review them all before we push them.
> Also, the dir.c patch might be out of date because of a patch I recently did that
> was recently added to for-next. I'll work with Andreas to expedite them so
> they can go into the next merge window.

Thanks for the update Bob.

My initial response to that would be; this patch-set ensures all of
the warnings are taken care of.  Removal of superfluous documentation
could be easily undertaken as part of a subsequent effort.

It would be good to have these warnings quashed for v5.13.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog