Hi Matti,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.12-rc6]
[also build test ERROR on next-20210401]
[cannot apply to regulator/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Extend-regulator-notification-support/20210406-151758
base:    e49d033bddf5b565044e2abe4241353959bc9120
config: i386-randconfig-m021-20210406 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/50f89bb3fbe5e4a21c48a9ca64065f3f3a668e56
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matti-Vaittinen/Extend-regulator-notification-support/20210406-151758
        git checkout 50f89bb3fbe5e4a21c48a9ca64065f3f3a668e56
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:16,
                    from arch/x86/include/asm/percpu.h:27,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from drivers/regulator/irq_helpers.c:10:
   drivers/regulator/irq_helpers.c: In function 'die_loudly':
>> drivers/regulator/irq_helpers.c:46:11: error: expected ')' before 'msg'
      46 |  pr_emerg(msg);
         |           ^~~
   include/linux/printk.h:301:21: note: in definition of macro 'pr_fmt'
     301 | #define pr_fmt(fmt) fmt
         |                     ^~~
   drivers/regulator/irq_helpers.c:46:2: note: in expansion of macro 'pr_emerg'
      46 |  pr_emerg(msg);
         |  ^~~~~~~~


vim +46 drivers/regulator/irq_helpers.c

    43	
    44	static void die_loudly(const char *msg)
    45	{
  > 46		pr_emerg(msg);
    47		BUG();
    48	}
    49	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org