From: Pratyush Yadav <p.yadav@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Benoit Parrot <bparrot@ti.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Alexandre Courbot <acourbot@chromium.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Helen Koike <helen.koike@collabora.com>,
Michael Tretter <m.tretter@pengutronix.de>,
Peter Chen <peter.chen@nxp.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<dmaengine@vger.kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Subject: Re: [PATCH 12/16] dt-bindings: media: Add DT bindings for TI CSI2RX driver
Date: Tue, 6 Apr 2021 23:43:27 +0530 [thread overview]
Message-ID: <20210406181325.62htotc2y4eag4ar@ti.com> (raw)
In-Reply-To: <YGbrcKPA9K8Ws0lv@pendragon.ideasonboard.com>
On 02/04/21 01:01PM, Laurent Pinchart wrote:
> On Thu, Apr 01, 2021 at 10:52:01AM -0500, Rob Herring wrote:
> > On Tue, Mar 30, 2021 at 11:03:44PM +0530, Pratyush Yadav wrote:
> > > TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate
> > > capture over a CSI-2 bus. The TI CSI2RX platform driver glues all the
> > > parts together.
> > >
> > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> > > ---
> > > .../devicetree/bindings/media/ti,csi2rx.yaml | 70 +++++++++++++++++++
> > > 1 file changed, 70 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/media/ti,csi2rx.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/ti,csi2rx.yaml b/Documentation/devicetree/bindings/media/ti,csi2rx.yaml
> > > new file mode 100644
> > > index 000000000000..ebd894364391
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/ti,csi2rx.yaml
> > > @@ -0,0 +1,70 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/ti,csi2rx.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: TI CSI2RX Wrapper Device Tree Bindings
> > > +
>
> A description would be useful, especially given that the TRM doesn't
> mention "CSI2RX".
Ok.
>
> > > +maintainers:
> > > + - Pratyush Yadav <p.yadav@ti.com>
> > > +
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - const: ti,csi2rx
> > > +
> > > + dmas:
> > > + description: RX DMA Channel 0
> >
> > items:
> > - description: RX DMA Channel 0
> >
> > Or just 'maxItems: 1'
> >
> > > +
> > > + dma-names:
> > > + items:
> > > + - const: rx0
> > > +
> > > + reg:
> > > + maxItems: 1
> > > + description: Base address and size of the TI wrapper registers.
> >
> > That's all 'reg' properties, drop 'description'.
>
> According to SPRUIL1B, there are four register banks for the CSI_RX_IF,
> and two register banks for the DPHY_RX. What's your plan to support
> these ? Not everything need to be implemented at once, but backward
> compatibility need to be taken into account in the design.
The CSI_RX_IF0_ECC_AGGR_CFG register bank is for safety requirements.
The driver does not use them. The CSI_RX_IF0_RX_SHIM_VBUSP_MMR_CSI2RXIF
register bank is for the TI wrapper around the Cadence CSI2RX bridge
that deals with DMA threads. This bank is what this binding is concerned
with. The CSI_RX_IF0_VBUS2APB_WRAP_VBUS_APB_CSI2RX bank is for the
Cadence CSI2RX bridge. The Cadence schema should deal with that. And
lastly, I don't know what the CSI_RX_IF0_CP_INTD_CFG_INTD_CFG bank is
for. The driver does not use it.
I don't forsee the first and last bank being used in Kernel, but if we
want to be safe I can change maxItems to 3. Sounds good?
>
> > > +
> > > + power-domains:
> > > + maxItems: 1
> > > + description:
> > > + PM domain provider node and an args specifier containing
> > > + the device id value.
> >
> > Drop.
> >
> > > +
> > > + ranges: true
> > > +
> > > + "#address-cells":
> > > + const: 2
> > > +
> > > + "#size-cells":
> > > + const: 2
> > > +
> > > +patternProperties:
> > > + "csi-bridge@":
> >
> > "^csi-bridge@"
> >
> > > + type: object
> > > + description: CSI2 bridge node.
> >
> > Just an empty node?
>
> Even if the node is optional, it would be useful to include it in the
> example below, to show how it's supposed to be used.
It is not optional. It should be the Cadence CSI2RX bridge node. Will
add it in the example. I also need to see if there is any way to make a
patternProperty a required property.
>
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - dmas
> > > + - dma-names
> > > + - power-domains
> > > + - "#address-cells"
> > > + - "#size-cells"
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + #include <dt-bindings/soc/ti,sci_pm_domain.h>
> > > +
> > > + ti_csi2rx0: ticsi2rx {
> > > + compatible = "ti,csi2rx";
> > > + dmas = <&main_udmap 0x4940>;
> > > + dma-names = "rx0";
> > > + reg = <0x0 0x4500000 0x0 0x1000>;
> > > + power-domains = <&k3_pds 26 TI_SCI_PD_EXCLUSIVE>;
> > > + #address-cells = <2>;
> > > + #size-cells = <2>;
> > > + };
>
> --
> Regards,
>
> Laurent Pinchart
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-04-06 18:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:33 [PATCH 00/16] CSI2RX support on J721E Pratyush Yadav
2021-03-30 17:33 ` [PATCH 01/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Pratyush Yadav
2021-03-30 17:33 ` [PATCH 02/16] phy: cdns-dphy: Prepare for Rx support Pratyush Yadav
2021-03-30 17:33 ` [PATCH 03/16] phy: cdns-dphy: Allow setting mode Pratyush Yadav
2021-04-02 10:38 ` Laurent Pinchart
2021-04-06 18:22 ` Pratyush Yadav
2021-03-30 17:33 ` [PATCH 04/16] phy: cdns-dphy: Add Rx support Pratyush Yadav
2021-03-30 17:33 ` [PATCH 05/16] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav
2021-03-31 9:24 ` Chunfeng Yun
2021-04-06 18:54 ` Pratyush Yadav
2021-04-08 8:13 ` Chunfeng Yun
2021-04-08 8:22 ` Tomi Valkeinen
2021-03-30 17:33 ` [PATCH 06/16] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav
2021-03-30 17:33 ` [PATCH 07/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav
2021-03-30 17:33 ` [PATCH 08/16] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav
2021-03-30 17:33 ` [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream Pratyush Yadav
2021-04-02 10:55 ` Laurent Pinchart
2021-04-06 17:53 ` Pratyush Yadav
2021-03-30 17:33 ` [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls Pratyush Yadav
2021-04-02 10:47 ` Laurent Pinchart
2021-04-06 15:11 ` Pratyush Yadav
2021-03-30 17:33 ` [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav
2021-04-04 13:24 ` Péter Ujfalusi
2021-04-06 15:09 ` Pratyush Yadav
2021-04-06 15:33 ` Péter Ujfalusi
2021-04-06 16:55 ` Pratyush Yadav
2021-04-06 17:10 ` Pratyush Yadav
2021-04-06 19:13 ` Péter Ujfalusi
2021-03-30 17:33 ` [PATCH 12/16] dt-bindings: media: Add DT bindings for TI CSI2RX driver Pratyush Yadav
2021-03-31 13:40 ` Rob Herring
2021-04-01 15:52 ` Rob Herring
2021-04-02 10:01 ` Laurent Pinchart
2021-04-02 10:53 ` Laurent Pinchart
2021-04-06 18:15 ` Pratyush Yadav
2021-04-06 18:13 ` Pratyush Yadav [this message]
2021-04-06 18:00 ` Pratyush Yadav
2021-04-01 15:52 ` Rob Herring
2021-03-30 17:33 ` [PATCH 13/16] media: ti-vpe: csi2rx: Add CSI2RX support Pratyush Yadav
2021-03-31 6:06 ` Tomi Valkeinen
2021-03-31 15:44 ` Benoit Parrot
2021-03-31 15:50 ` Laurent Pinchart
2021-04-06 15:05 ` Pratyush Yadav
2021-04-04 13:38 ` Péter Ujfalusi
2021-03-30 17:33 ` [PATCH 14/16] dt-bindings: phy: Convert Cadence DPHY binding to YAML Pratyush Yadav
2021-04-02 10:23 ` Laurent Pinchart
2021-04-06 18:51 ` Pratyush Yadav
2021-03-30 17:33 ` [PATCH 15/16] dt-bindings: phy: cdns,dphy: make clocks optional Pratyush Yadav
2021-04-02 10:31 ` Laurent Pinchart
2021-04-06 18:48 ` Pratyush Yadav
2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: add power-domains property Pratyush Yadav
2021-04-02 10:35 ` Laurent Pinchart
2021-04-06 18:23 ` Pratyush Yadav
2021-03-31 9:33 ` [PATCH 00/16] CSI2RX support on J721E Vinod Koul
2021-03-31 11:40 ` Pratyush Yadav
2021-03-31 13:06 ` Vinod Koul
2021-03-31 13:51 ` Pratyush Yadav
2021-04-02 10:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406181325.62htotc2y4eag4ar@ti.com \
--to=p.yadav@ti.com \
--cc=acourbot@chromium.org \
--cc=bparrot@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=m.tretter@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=peter.chen@nxp.com \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).