* [PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order
@ 2021-04-06 23:35 Aditya Pakki
2021-04-20 7:19 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2021-04-06 23:35 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Gustavo A. R. Silva, Sam Ravnborg, dri-devel, linux-fbdev,
linux-kernel
The resource release in sm501fb_remove() is not in the inverse order of
sm501fb_probe(), for the buffers. Release the info object after
deallocating the buffers.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/video/fbdev/sm501fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index 6a52eba64559..4c32c9e88850 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -2060,11 +2060,11 @@ static int sm501fb_remove(struct platform_device *pdev)
unregister_framebuffer(fbinfo_pnl);
sm501fb_stop(info);
- kfree(info);
framebuffer_release(fbinfo_pnl);
framebuffer_release(fbinfo_crt);
+ kfree(info);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order
2021-04-06 23:35 [PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order Aditya Pakki
@ 2021-04-20 7:19 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-04-20 7:19 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Gustavo A. R. Silva, Sam Ravnborg, dri-devel, linux-fbdev,
linux-kernel
On Tue, Apr 06, 2021 at 06:35:17PM -0500, Aditya Pakki wrote:
> The resource release in sm501fb_remove() is not in the inverse order of
> sm501fb_probe(), for the buffers. Release the info object after
> deallocating the buffers.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/video/fbdev/sm501fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
> index 6a52eba64559..4c32c9e88850 100644
> --- a/drivers/video/fbdev/sm501fb.c
> +++ b/drivers/video/fbdev/sm501fb.c
> @@ -2060,11 +2060,11 @@ static int sm501fb_remove(struct platform_device *pdev)
> unregister_framebuffer(fbinfo_pnl);
>
> sm501fb_stop(info);
> - kfree(info);
>
> framebuffer_release(fbinfo_pnl);
> framebuffer_release(fbinfo_crt);
>
> + kfree(info);
> return 0;
> }
>
> --
> 2.25.1
>
There is no function change here at all, please stop it with pointless
patches.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-20 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 23:35 [PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order Aditya Pakki
2021-04-20 7:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).