From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Clemens Gruber <clemens.gruber@pqgruber.com>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Sven Van Asbroeck <TheSven73@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag
Date: Wed, 7 Apr 2021 07:33:57 +0200 [thread overview]
Message-ID: <20210407053357.ok62rqpgyqou53m3@pengutronix.de> (raw)
In-Reply-To: <20210406164140.81423-4-clemens.gruber@pqgruber.com>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote:
> Add the flag and corresponding documentation for the new PWM staggering
> mode feature.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
For the record, I don't like this and still prefer to make this
staggering explicit for the consumer by expanding struct pwm_state with
an .offset member to shift the active phase in the period.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-07 5:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 16:41 [PATCH v7 1/8] pwm: pca9685: Switch to atomic API Clemens Gruber
2021-04-06 16:41 ` [PATCH v7 2/8] pwm: pca9685: Support hardware readout Clemens Gruber
2021-04-07 5:31 ` Uwe Kleine-König
2021-04-07 7:33 ` Clemens Gruber
2021-04-07 9:09 ` Uwe Kleine-König
2021-04-07 9:53 ` Clemens Gruber
2021-04-06 16:41 ` [PATCH v7 3/8] pwm: pca9685: Improve runtime PM behavior Clemens Gruber
2021-04-09 13:03 ` Thierry Reding
2021-04-09 16:08 ` Clemens Gruber
2021-04-06 16:41 ` [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag Clemens Gruber
2021-04-07 5:33 ` Uwe Kleine-König [this message]
2021-04-09 12:27 ` Thierry Reding
2021-04-10 14:01 ` Uwe Kleine-König
2021-04-10 14:02 ` Uwe Kleine-König
2021-04-06 16:41 ` [PATCH v7 5/8] pwm: core: " Clemens Gruber
2021-04-07 5:46 ` Uwe Kleine-König
2021-04-07 20:21 ` Clemens Gruber
2021-04-07 21:34 ` Uwe Kleine-König
2021-04-08 12:50 ` Thierry Reding
2021-04-08 15:51 ` Clemens Gruber
2021-04-08 17:36 ` Uwe Kleine-König
2021-04-08 18:14 ` Clemens Gruber
2021-04-09 11:25 ` Thierry Reding
2021-04-09 16:02 ` Clemens Gruber
2021-04-09 21:35 ` Uwe Kleine-König
2021-04-09 11:10 ` Thierry Reding
2021-04-06 16:41 ` [PATCH v7 6/8] pwm: pca9685: " Clemens Gruber
2021-04-06 16:41 ` [PATCH v7 7/8] pwm: pca9685: Restrict period change for enabled PWMs Clemens Gruber
2021-04-07 6:12 ` Uwe Kleine-König
2021-04-07 20:41 ` Clemens Gruber
2021-04-07 21:38 ` Uwe Kleine-König
2021-04-06 16:41 ` [PATCH v7 8/8] pwm: pca9685: Add error messages for failed regmap calls Clemens Gruber
2021-04-07 6:16 ` Uwe Kleine-König
2021-04-07 20:47 ` Clemens Gruber
2021-04-07 21:41 ` Uwe Kleine-König
2021-04-07 5:24 ` [PATCH v7 1/8] pwm: pca9685: Switch to atomic API Uwe Kleine-König
2021-04-07 7:26 ` Clemens Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407053357.ok62rqpgyqou53m3@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=TheSven73@gmail.com \
--cc=clemens.gruber@pqgruber.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).