From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC99C433B4 for ; Wed, 7 Apr 2021 10:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 577936108B for ; Wed, 7 Apr 2021 10:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237634AbhDGKuy (ORCPT ); Wed, 7 Apr 2021 06:50:54 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:38897 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351513AbhDGKtP (ORCPT ); Wed, 7 Apr 2021 06:49:15 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 14CC7580985; Wed, 7 Apr 2021 06:48:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 07 Apr 2021 06:48:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=bryhBUK4gj1uG2j7gqn9cxD18k9 Ai3R9q5ZzCV5V3d4=; b=M7Jm5mG+jkqykilbQjrGoKnBqe59FZ+AZ/vt3iiYI6L HzkV/0KSdaJKmhK9O0GGftGQA+cIyIt/zO/pWHtb9qAZyqk9iDgC0tLmbEhqFX0h C9WLclqcUaPg+fGc8k9soyiLDCfLcgw7g6bdEU6vMu8EZnfowiZPm3JXmzlvmng7 DEN9ennpkMrJdNVMH2PGuELqFqwakYfTtJA+tR270pwxmp9dLFV8Z7zEl9zcb6Z/ /tu3QFj1Zu5ixrS+257o9M4TDoU0kJi62X2KeyRLD6/duAlzdP5ECz/tSQYzsrQb 30IwXXyy01GADkbXxcfUJftKhafypQx1D0I2ytBYRSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=bryhBU K4gj1uG2j7gqn9cxD18k9Ai3R9q5ZzCV5V3d4=; b=I/XVohD3GiMmHpORrupzI8 gy7eoqU6Dhi8A1O4K3BE5ED4oN+hG06ADg9a0GwvdvrqhhM/cI+6Rj7J0078IFTI irPfkwj+F6hbQTjfi0tQAoJwYQ1DzEAVeXtIAxirn59UTJANy0IV+XqspIV8/PnT LoYPbxK0GDw6gmzvcqMWIZZUhndj0oa5nyjDtQsihMyNUXjmTMvGv6MA/j9UZo9o PBpNxjtx2IKnS2mflIJmn1sBApCg+htks/Qy4K4/iXQ3hKUC0P6NCOUvt6UpKh5k 0TNOAsypIiolBO0uPE+xpMjeK3RJUHxxic3lZmJ3NHPZTutVFLhkeHGk5BkzW3Sg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejjedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 9D2051080063; Wed, 7 Apr 2021 06:48:55 -0400 (EDT) Date: Wed, 7 Apr 2021 12:48:54 +0200 From: Maxime Ripard To: Kevin Tang Cc: Maarten Lankhorst , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Orson Zhai , Chunyan Zhang , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , devicetree@vger.kernel.org Subject: Re: [PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Message-ID: <20210407104854.fgn67pvau7dchcm2@gilmour> References: <20210222132822.7830-1-kevin3.tang@gmail.com> <20210222132822.7830-7-kevin3.tang@gmail.com> <20210324112745.n76qhrbhzyfunmkd@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="znbdfkroerihtnuv" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --znbdfkroerihtnuv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 31, 2021 at 09:47:12AM +0800, Kevin Tang wrote: > > > diff --git a/drivers/gpu/drm/sprd/Makefile > > b/drivers/gpu/drm/sprd/Makefile > > > index 6c25bfa99..d49f4977b 100644 > > > --- a/drivers/gpu/drm/sprd/Makefile > > > +++ b/drivers/gpu/drm/sprd/Makefile > > > @@ -1,5 +1,8 @@ > > > # SPDX-License-Identifier: GPL-2.0 > > > > > > obj-y := sprd_drm.o \ > > > - sprd_dpu.o > > > - > > > + sprd_dpu.o \ > > > + sprd_dsi.o \ > > > + dw_dsi_ctrl.o \ > > > + dw_dsi_ctrl_ppi.o \ > > > > So it's a designware IP? There's a driver for it already that seems > > fairly similar: > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > > > Our dw dsi controller is not a standard synopsys ip, we have updated a lot > on the basic ip version, > the entire control register is different, i have cc to drm/bridge reviewers > and maintainers. You should make it more obvious then in a comment or in the name of the driver. If it's fairly different from the original IP from Synopsys, maybe you should just drop the reference to the name? Maxime --znbdfkroerihtnuv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYG2OFgAKCRDj7w1vZxhR xTGeAP43GxaV8bVqijzlTRpxU9Akr4e/ozKykBfR4+jAeDva5gD+K8sElBZsuEnb D1HmG0QxEpBwGPRikmgacH+4dSDIAA0= =+gJE -----END PGP SIGNATURE----- --znbdfkroerihtnuv--