From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null
Date: Wed, 7 Apr 2021 17:38:46 +0200 [thread overview]
Message-ID: <20210407153845.GB1590@agape.jhs> (raw)
In-Reply-To: <YG3QGq0T/cO2kdFN@kroah.com>
On Wed, Apr 07, 2021 at 05:30:34PM +0200, Greg KH wrote:
> On Wed, Apr 07, 2021 at 05:25:34PM +0200, Fabio Aiuto wrote:
> > On Wed, Apr 07, 2021 at 05:14:00PM +0200, Greg KH wrote:
> > > On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote:
> > > > fix following post-commit hook checkpatch warnings:
> > > >
> > > > CHECK: Comparison to NULL could be written "!psta"
> > > > 97: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:2115:
> > > > + if (psta == NULL)
> > > >
> > > > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > > > ---
> > > > drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Nit, your subject line has "drivers:" not "staging:" here. Be a bit
> > > more careful next time please.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > sorry, you can drop them off the staging-testing branch and I will resend you all if you want,
>
> Nah, it's not worth it, I'll keep them for now :)
:-D
next prev parent reply other threads:[~2021-04-07 15:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 13:49 [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Fabio Aiuto
2021-04-07 13:49 ` [PATCH 01/19] staging: rtl8723bs: remove DBG_871X log argument Fabio Aiuto
2021-04-07 13:49 ` [PATCH 02/19] staging: rtl8723bs: remove all DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 03/19] staging: rtl8723bs: remove DBG_871CX log unmatched by cocci Fabio Aiuto
2021-04-07 13:49 ` [PATCH 04/19] staging: rtl8723bs: remove commented out DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 05/19] staging: rtl8723bs: remove DBG_871X macro definitions Fabio Aiuto
2021-04-07 13:49 ` [PATCH 06/19] staging: rtl8723bs: remove all if-else empty blocks left by DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 15:14 ` Greg KH
2021-04-07 15:25 ` Fabio Aiuto
2021-04-07 15:30 ` Greg KH
2021-04-07 15:38 ` Fabio Aiuto [this message]
2021-04-07 13:49 ` [PATCH 08/19] staging: rtl8723bs: put constant on the right side in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 09/19] staging: rtl8723bs: remove empty for cycles left by DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 10/19] staging: rtl8723bs: remove empty tracing function dump_rx_packet Fabio Aiuto
2021-04-07 13:49 ` [PATCH 11/19] staging: rtl8723bs: remove empty #ifdef blocks after DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on DBG_871X removal sites Fabio Aiuto
2021-04-13 14:52 ` Dan Carpenter
2021-04-14 8:32 ` Joe Perches
2021-04-07 13:49 ` [PATCH 13/19] staging: rtl8723bs: remove unnecessary parentheses in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 14/19] staging: rtl8723bs: add spaces around operators Fabio Aiuto
2021-04-07 13:49 ` [PATCH 15/19] staging: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 13:49 ` [PATCH 16/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 13:49 ` [PATCH 17/19] staging: rtl8723bs: fix comparison in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 18/19] staging: rtl8723bs: split long lines Fabio Aiuto
2021-04-13 14:57 ` Dan Carpenter
2021-04-14 8:17 ` [PATCH] staging: rtl8723bs: fix indentation issue introduced by long line split Fabio Aiuto
2021-04-07 13:49 ` [PATCH 19/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 15:14 ` [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Greg KH
2021-04-07 16:49 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407153845.GB1590@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).