From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86B5C43470 for ; Thu, 8 Apr 2021 07:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F02561157 for ; Thu, 8 Apr 2021 07:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbhDHHGX (ORCPT ); Thu, 8 Apr 2021 03:06:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbhDHHGV (ORCPT ); Thu, 8 Apr 2021 03:06:21 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2BF3C061762 for ; Thu, 8 Apr 2021 00:06:09 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id x4so1111804edd.2 for ; Thu, 08 Apr 2021 00:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=z4Gitq6pVFDGPa5UrDIJQObnLNdxwY706RuaVL/8cJQ=; b=Rq/AVPm1jCL9qyyHKxT5usmTELeBq1QBK7S0jE9FhIpcOnkmIE1MFYUSaaLB+fbeG4 woViT2OkK6JUUf3A2pifrsX5TFDVEZfZya+OSIC/IKAg4osGnjzTTNPpvYzlhqNEJGTc CyQuygiOyddbOLcV9fNt8j8cWcoY5jPX7ERVGHmcm4UIxIqYaDrUz/IJFIT1ktLpb4rd dhA3O4NnNSbVMZrBVtPWqo2gxWeYgW/qSBaWA8dFh8D4M8VVcD4zXhwnNPoFZ1JuOnq0 a1nKocWIAJawxgrF7mtFwTlMC+n6jAdNlz5Tl3pqZOd3kKWkQc0WWuZq0v4zfd9PMsx9 xj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=z4Gitq6pVFDGPa5UrDIJQObnLNdxwY706RuaVL/8cJQ=; b=NkoIZO2+DQzLPdTPd0XkBtNOghkYKVFbtR0Mt1FuVM/eRBl1vXweT9rCqg0YBUg7rA sLhE1azhuSGJ4JUpXz/HRCX5qKBDBDicA2xOIFlniCa+dcb/7JqiriAI63JFLzdue4Av +LTySi1SYyNRsaqc7mzgqCJTinQlLALFWt2juB/c3f8JossEaCLHdx4rQM+3mZhFDhaO yqzPkU5JZII/KX+wv0hTsbK08AckhskBpLsvjxDVp3y7IqoVi2jxQnhxtftpfZ1ZZLI2 n1vqeBqu+kNNpCGf2queLbZSvEFT9uBeXHhwRUVTzkmK43LRbWSrkZEzqcDc099jnXfZ Bwqg== X-Gm-Message-State: AOAM5301iamqzhqx0T4HPAUIsYPh2nS1/MuLUo3nP9grXK4CM8MLq6eJ QbSyLdn5OXCWzi5uKUd2VDNH4g== X-Google-Smtp-Source: ABdhPJxnL59ZtT6Iah9N++cMUYV0rXC755tzrsh7H6THlQikyo2EcZ08HAyhG/iIV512tuxRYVlbrA== X-Received: by 2002:a05:6402:4d1:: with SMTP id n17mr9243636edw.118.1617865568643; Thu, 08 Apr 2021 00:06:08 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id q16sm13810809ejd.15.2021.04.08.00.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 00:06:08 -0700 (PDT) Date: Thu, 8 Apr 2021 08:06:05 +0100 From: Lee Jones To: Benjamin Tissoires Cc: lkml , Alexandre Torgue , Anssi Hannula , Bruno =?iso-8859-1?Q?Pr=E9mont?= , Christian =?iso-8859-1?Q?K=F6nig?= , Daniel Drubin , Dario Pagani , dri-devel@lists.freedesktop.org, Henrik Rydberg , Jiri Kosina , Jonathan Cameron , Kai-Heng Feng , Kim Kuparinen , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linaro-mm-sig@lists.linaro.org, Linux ARM , linux-iio , "open list:HID CORE LAYER" , linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Linux USB Mailing List , Lopez Casado , "L. Vinyard, Jr" , Masaki Ota , Maxime Coquelin , message to , Michael Haboustak , Rushikesh S Kadam , Srinivas Pandruvada , Sumit Semwal , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Vojtech Pavlik , Zhang Lixu Subject: Re: [RESEND 00/25] Rid W=1 warnings from HID Message-ID: <20210408070605.GC2961413@dell> References: <20210326143458.508959-1-lee.jones@linaro.org> <20210406085605.GS2916463@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > > > > > > Lee Jones (25): > > > HID: intel-ish-hid: Remove unused variable 'err' > > > HID: ishtp-hid-client: Move variable to where it's actually used > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > > > HID: intel-ish: Supply some missing param descriptions > > > HID: intel-ish: Fix a naming disparity and a formatting error > > > HID: usbhid: Repair a formatting issue in a struct description > > > HID: intel-ish-hid: Fix a little doc-rot > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > > > HID: hid-alps: Correct struct misnaming > > > HID: intel-ish-hid: Fix potential copy/paste error > > > HID: hid-core: Fix incorrect function name in header > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > > > header > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > > > HID: hid-picolcd_core: Remove unused variable 'ret' > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > > > abuses > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > > > HID: hid-uclogic-params: Ensure function names are present and correct > > > in kernel-doc headers > > > HID: hid-sensor-custom: Remove unused variable 'ret' > > > HID: wacom_sys: Demote kernel-doc abuse > > > HID: hid-sensor-hub: Remove unused struct member 'quirks' > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > > > definition > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > > > These have been on the list for a couple of weeks now. > > > > Is there anything I can do to help expedite their merge? > > > > I'm concerned since -rc6 has just been released. > > Sorry for the delay. > > I am currently queuing them locally and running a few tests on them. I > don't expect anything to happen, but better be safe than anything. > > FWIW, I am splitting the series in 3: > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish > - the thrustmaster one in for-5.13/thrustmaster > - the rest (13 patches) will be sent in for-5.13/warnings. Sounds good to me. Thanks Benjamin. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog