From: Yu Kuai <yukuai3@huawei.com>
To: <joern@lazybastard.org>, <miquel.raynal@bootlin.com>,
<richard@nod.at>, <vigneshr@ti.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<yukuai3@huawei.com>, <yi.zhang@huawei.com>
Subject: [PATCH V2] mtd: phram: Fix error return code in phram_setup()
Date: Thu, 8 Apr 2021 21:38:12 +0800 [thread overview]
Message-ID: <20210408133812.1209798-1-yukuai3@huawei.com> (raw)
In-Reply-To: <20210408144610.0c0686ae@xps13>
Return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/mtd/devices/phram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index 5b04ae6c3057..6ed6c51fac69 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -270,6 +270,7 @@ static int phram_setup(const char *val)
if (len == 0 || erasesize == 0 || erasesize > len
|| erasesize > UINT_MAX || rem) {
parse_err("illegal erasesize or len\n");
+ ret = -EINVAL;
goto error;
}
--
2.25.4
next prev parent reply other threads:[~2021-04-08 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:15 [PATCH 0/3] code optimization for mtd Yu Kuai
2021-04-08 11:15 ` [PATCH 1/3] mtd: rawnand: mtk: remove redundant dev_err call in mtk_ecc_probe() Yu Kuai
2021-05-10 9:10 ` Miquel Raynal
2021-04-08 11:15 ` [PATCH 2/3] mtd: plat-ram: remove redundant dev_err call in platram_probe() Yu Kuai
2021-05-10 9:10 ` Miquel Raynal
2021-04-08 11:15 ` [PATCH 3/3] mtd: phram: Fix error return code in phram_setup() Yu Kuai
2021-04-08 12:46 ` Miquel Raynal
2021-04-08 13:26 ` yukuai (C)
2021-04-08 13:38 ` Yu Kuai [this message]
2021-04-08 13:33 ` [PATCH V2] " Miquel Raynal
2021-05-10 9:10 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408133812.1209798-1-yukuai3@huawei.com \
--to=yukuai3@huawei.com \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).