From: Oded Gabbay <ogabbay@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Tomer Tayar <ttayar@habana.ai>
Subject: [PATCH 1/7] habanalabs/gaudi: clear QM errors only if not in stop_on_err mode
Date: Thu, 8 Apr 2021 18:22:28 +0300 [thread overview]
Message-ID: <20210408152234.15383-1-ogabbay@kernel.org> (raw)
From: Tomer Tayar <ttayar@habana.ai>
Clearing QM errors by the driver will prevent these H/W blocks from
stopping in case they are configured to stop on errors, so perform this
clearing only if this mode is not in use.
Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---
drivers/misc/habanalabs/gaudi/gaudi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index 03d3fb643e79..791434278904 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -7086,7 +7086,8 @@ static void gaudi_handle_qman_err_generic(struct hl_device *hdev,
}
/* Write 1 clear errors */
- WREG32(glbl_sts_addr + 4 * i, glbl_sts_clr_val);
+ if (!hdev->stop_on_err)
+ WREG32(glbl_sts_addr + 4 * i, glbl_sts_clr_val);
}
arb_err_val = RREG32(arb_err_addr);
--
2.25.1
next reply other threads:[~2021-04-08 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 15:22 Oded Gabbay [this message]
2021-04-08 15:22 ` [PATCH 2/7] habanalabs: send dynamic msi-x indexes to f/w Oded Gabbay
2021-04-08 15:22 ` [PATCH 3/7] habanalabs: move dram scrub to free sequence Oded Gabbay
2021-04-08 15:22 ` [PATCH 4/7] habanalabs/gaudi: derive security status from pci id Oded Gabbay
2021-04-08 15:22 ` [PATCH 5/7] habanalabs/gaudi: skip iATU if F/W security is enabled Oded Gabbay
2021-04-08 15:22 ` [PATCH 6/7] habanalabs: print on f/w boot unknown error Oded Gabbay
2021-04-08 15:22 ` [PATCH 7/7] habanalabs: update to latest F/W communication header Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408152234.15383-1-ogabbay@kernel.org \
--to=ogabbay@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).