From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: linux-mtd@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2
Date: Thu, 8 Apr 2021 17:49:22 +0200 [thread overview]
Message-ID: <20210408174922.55c1149f@xps13> (raw)
In-Reply-To: <CAFr9PXk-PNWBa9VPriP3nLUqdhtm6uPnbG3n4_rRCdF5YvS7OQ@mail.gmail.com>
Hi Daniel,
Daniel Palmer <daniel@0x0f.com> wrote on Wed, 7 Apr 2021 21:01:01 +0900:
> Hi Miquel,
>
> On Wed, 7 Apr 2021 at 17:02, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > You may look at micron_8_ecc_get_status() helper to guide you. But
> > IMHO, if there are 0-3 bf, you should probably assume there were 3 bf
> > and return 3, if there were 4, return 4, if it's uncorrectable return
> > -EBADMSG otherwise -EINVAL.
>
> Understood.
>
> > We should verify that this does not mess with UBI wear leveling
> > though. Please check that returning 3-bit errors no matter the
> > actual number of flipped bits does not lead UBI to move the data away
> > (I think it's fine but we need to be sure otherwise the implementation
> > proposal is not valid).
>
> Ok. I'm not sure how to check that yet but I'll look into it.
>
You can probably check the threshold in sysfs
(/sys/class/mtd/mtdX/*threshold*).
Thanks,
Miquèl
prev parent reply other threads:[~2021-04-08 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 9:57 [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2 Daniel Palmer
2021-02-15 10:24 ` Miquel Raynal
2021-02-15 10:53 ` Daniel Palmer
2021-02-15 11:16 ` Miquel Raynal
2021-02-15 11:34 ` Daniel Palmer
2021-03-22 12:44 ` Daniel Palmer
2021-03-22 18:32 ` Miquel Raynal
2021-03-23 9:33 ` Daniel Palmer
2021-03-23 10:32 ` Miquel Raynal
2021-03-23 11:47 ` Daniel Palmer
2021-03-23 14:06 ` Miquel Raynal
2021-03-23 14:14 ` Daniel Palmer
2021-03-26 14:09 ` Daniel Palmer
2021-04-07 8:02 ` Miquel Raynal
2021-04-07 12:01 ` Daniel Palmer
2021-04-08 15:49 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408174922.55c1149f@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=daniel@0x0f.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).