From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44192C43461 for ; Fri, 9 Apr 2021 10:24:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2008560240 for ; Fri, 9 Apr 2021 10:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232850AbhDIKYj (ORCPT ); Fri, 9 Apr 2021 06:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233129AbhDIKYL (ORCPT ); Fri, 9 Apr 2021 06:24:11 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69BB3C061760 for ; Fri, 9 Apr 2021 03:23:57 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 18so5940638edx.3 for ; Fri, 09 Apr 2021 03:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3X2i/TtHTFpzqhDJcZ/Ryoyq1t75AmO3pNenaRT82zk=; b=N7Ix2SbgX12DZw0PuE9agptLItNucgGZKtEZUyJgDS+4mZh6GOAQT+rynkXF33t3ve 3OwbLhGkPMg1rJ1TYfigHAy7YsvNBilWjWT1+FqTc8v0D3B4jiss1MDPFnip4emIqYoN Qctyd0ifBO6b6bo1qD6z5YkOUBK4moQ39Six+JBTcaoFxy23/mV0PpxBdQfVepBH5Sva c94DKASQuqWeNKxQCl6SS06nDbvglBiQnHwZETj3YiP223tlh5ONZhqApuggoJ3N7cJp OJzQUB1PhegnNiBPFEVfZKwxHljTOS2sZYupmkz7M0+0H0UQHkx3drnyfgPSh4XyTa6r UJfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3X2i/TtHTFpzqhDJcZ/Ryoyq1t75AmO3pNenaRT82zk=; b=TOyHaY5R/ZvhiEmxNWlM5dRkTzrk2kohkIXL6g7/EG1+M+m/eWLpXnu3SVQRUAL8ru lzoG8lWkaoJ3tTZoyKkVVdci7103fPaFOHJdYU1IdvXnXvLnynJbYexIUZ4B5VHCzExi hoFdjB1A5s2Mcj5GN4OhwE3rmWPmpMdajISr4fZ5scArDJNQrJzSDKy98aKmruM8UtKX 5RlMZSisO8uEBHXSY79rfRpRgPEZzosTuqAOsKVvbtGnOT7xUTE4lRAiAJIPfZuilrfj Mde/xynvFTyLUcqMrZnszJa1j67v+W9WXlyvIvn7V1FjLpD+q0Amep7hLqI88O0fjKc1 oUiQ== X-Gm-Message-State: AOAM531ZJK7TQcY7K9rR6DhX1FXfMQsZbN0s03Pm+Ah3ays10aM981Z2 q3wQw2hpNoFTuSjyDbU5dDI= X-Google-Smtp-Source: ABdhPJy9DQhPUMHc/oyh2sCyIWQRM29bUH8VsHiwX/1jI3K30I/tBHmjxMsCIxYQLXOTf1b3aYO69g== X-Received: by 2002:a05:6402:254a:: with SMTP id l10mr16756622edb.160.1617963836242; Fri, 09 Apr 2021 03:23:56 -0700 (PDT) Received: from agape.jhs ([5.171.72.173]) by smtp.gmail.com with ESMTPSA id i16sm605517ejc.106.2021.04.09.03.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 03:23:55 -0700 (PDT) Date: Fri, 9 Apr 2021 12:23:53 +0200 From: Fabio Aiuto To: Dan Carpenter Cc: gregkh@linuxfoundation.org, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and os_dep/ Message-ID: <20210409102352.GB1396@agape.jhs> References: <85338f2b2cffb530efbd987064d146fc2be49c72.1617640221.git.fabioaiuto83@gmail.com> <20210409101252.GL6048@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409101252.GL6048@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 09, 2021 at 01:12:53PM +0300, Dan Carpenter wrote: > On Mon, Apr 05, 2021 at 06:49:49PM +0200, Fabio Aiuto wrote: > > diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c > > index 9b16265b543d..f52cc4e7a6e6 100644 > > --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c > > +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c > > @@ -1785,7 +1785,6 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel, > > /* > > if (band_type == BAND_ON_5G && pwr_lmt == MAX_POWER_INDEX) { > > if (idx_bandwidth == 0 || idx_bandwidth == 1) { > > - RT_TRACE(COMP_INIT, DBG_LOUD, ("No power limit table of the specified band %d, bandwidth %d, ratesection %d, rf path %d\n", > > idx_band, idx_bandwidth, > > idx_rate_sctn, rf_path)); > > if (idx_rate_sctn == 2) > > This won't compile. > > regards, > dan carpenter > > ouch you're right! In this case we are safe because it's commented code. Moreover, this is also the same 5G code block I remove later in the same patchset. I'm sorry for inattention, what's best now? thank you, fabio