* [PATCH -next] soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe()
@ 2021-04-09 11:02 Qiheng Lin
2021-04-26 18:02 ` Neil Armstrong
2021-05-04 0:05 ` Kevin Hilman
0 siblings, 2 replies; 3+ messages in thread
From: Qiheng Lin @ 2021-04-09 11:02 UTC (permalink / raw)
To: linqiheng, Kevin Hilman
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, kernel-janitors,
Hulk Robot
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
drivers/soc/amlogic/meson-clk-measure.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
index e1957476a006..6dd190270123 100644
--- a/drivers/soc/amlogic/meson-clk-measure.c
+++ b/drivers/soc/amlogic/meson-clk-measure.c
@@ -626,10 +626,8 @@ static int meson_msr_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(base)) {
- dev_err(&pdev->dev, "io resource mapping failed\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
priv->regmap = devm_regmap_init_mmio(&pdev->dev, base,
&meson_clk_msr_regmap_config);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe()
2021-04-09 11:02 [PATCH -next] soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe() Qiheng Lin
@ 2021-04-26 18:02 ` Neil Armstrong
2021-05-04 0:05 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2021-04-26 18:02 UTC (permalink / raw)
To: Qiheng Lin, Kevin Hilman
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, kernel-janitors,
Hulk Robot
On 09/04/2021 13:02, Qiheng Lin wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> drivers/soc/amlogic/meson-clk-measure.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
> index e1957476a006..6dd190270123 100644
> --- a/drivers/soc/amlogic/meson-clk-measure.c
> +++ b/drivers/soc/amlogic/meson-clk-measure.c
> @@ -626,10 +626,8 @@ static int meson_msr_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(base)) {
> - dev_err(&pdev->dev, "io resource mapping failed\n");
> + if (IS_ERR(base))
> return PTR_ERR(base);
> - }
>
> priv->regmap = devm_regmap_init_mmio(&pdev->dev, base,
> &meson_clk_msr_regmap_config);
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe()
2021-04-09 11:02 [PATCH -next] soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe() Qiheng Lin
2021-04-26 18:02 ` Neil Armstrong
@ 2021-05-04 0:05 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2021-05-04 0:05 UTC (permalink / raw)
To: Qiheng Lin
Cc: Hulk Robot, linux-arm-kernel, linux-amlogic, linux-kernel,
kernel-janitors
On Fri, 9 Apr 2021 19:02:43 +0800, Qiheng Lin wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied, thanks!
[1/1] soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe()
commit: 4f2f0162a389196fb4092aee93ef4a89f96390be
Best regards,
--
Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-04 0:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 11:02 [PATCH -next] soc: amlogic: meson-clk-measure: remove redundant dev_err call in meson_msr_probe() Qiheng Lin
2021-04-26 18:02 ` Neil Armstrong
2021-05-04 0:05 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).