From: Jakub Kicinski <kuba@kernel.org>
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible
Date: Fri, 9 Apr 2021 11:54:55 -0700 [thread overview]
Message-ID: <20210409115455.49e24450@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210409180605.78599-3-mcroce@linux.microsoft.com>
On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote:
> From: Matteo Croce <mcroce@microsoft.com>
>
> use the new helper macro skb_for_each_frag() which allows to iterate
> through all the SKB fragments.
>
> The patch was created with Coccinelle, this was the semantic patch:
Bunch of set but not used warnings here. Please make sure the code
builds cleanly allmodconfig, W=1 C=1 before posting.
What pops to mind (although quite nit picky) is the question if the
assembly changes much between driver which used to cache nr_frags and
now always going skb_shinfo(skb)->nr_frags? It's a relatively common
pattern.
next prev parent reply other threads:[~2021-04-09 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 18:06 [PATCH net-next 0/3] introduce skb_for_each_frag() Matteo Croce
2021-04-09 18:06 ` [PATCH net-next 1/3] skbuff: add helper to walk over the fraglist Matteo Croce
2021-04-09 18:06 ` [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible Matteo Croce
2021-04-09 18:54 ` Jakub Kicinski [this message]
2021-04-09 20:44 ` Matteo Croce
2021-04-09 21:28 ` Jakub Kicinski
2021-04-10 0:53 ` Matteo Croce
2021-04-09 21:21 ` kernel test robot
2021-04-10 0:27 ` kernel test robot
2021-04-09 18:06 ` [PATCH net-next 3/3] net: use skb_for_each_frag() in illegal_highdma() Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409115455.49e24450@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).