From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C796C433ED for ; Fri, 9 Apr 2021 12:05:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B7AC611BF for ; Fri, 9 Apr 2021 12:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233852AbhDIMGC (ORCPT ); Fri, 9 Apr 2021 08:06:02 -0400 Received: from gate.crashing.org ([63.228.1.57]:45655 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231402AbhDIMGA (ORCPT ); Fri, 9 Apr 2021 08:06:00 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 139C2LKn009728; Fri, 9 Apr 2021 07:02:21 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 139C2KHA009727; Fri, 9 Apr 2021 07:02:20 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 9 Apr 2021 07:02:20 -0500 From: Segher Boessenkool To: Christophe Leroy Cc: Yu Kuai , mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH 2/2] powerpc: make 'boot_text_mapped' static Message-ID: <20210409120220.GE26583@gate.crashing.org> References: <20210408011801.557004-1-yukuai3@huawei.com> <20210408011801.557004-3-yukuai3@huawei.com> <5b91cd3f-d171-f510-7dae-8cbabb13b23c@csgroup.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5b91cd3f-d171-f510-7dae-8cbabb13b23c@csgroup.eu> User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Thu, Apr 08, 2021 at 07:04:35AM +0200, Christophe Leroy wrote: > Le 08/04/2021 à 03:18, Yu Kuai a écrit : > >-int boot_text_mapped __force_data = 0; > >+static int boot_text_mapped __force_data; > > Are you sure the initialisation to 0 can be removed ? Usually > initialisation to 0 is not needed because not initialised variables go in > the BSS section which is zeroed at startup. But here the variable is > flagged with __force_data so it is not going in the BSS section. Any non-automatic (i.e. function-scope, not static) variable is initialised to 0. See e.g. C11 6.7.9/10 (this has been like that since times immemorial, C90 anyway). Segher