From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60A84C43460 for ; Sun, 11 Apr 2021 17:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42F3B610C8 for ; Sun, 11 Apr 2021 17:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233514AbhDKREh (ORCPT ); Sun, 11 Apr 2021 13:04:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235737AbhDKREd (ORCPT ); Sun, 11 Apr 2021 13:04:33 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6505C06138B for ; Sun, 11 Apr 2021 10:04:16 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id j7so5094374plx.2 for ; Sun, 11 Apr 2021 10:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BTSmYzl0sYL6U3pEfv9/5A9umdXLofLexJIK/i1h5Zk=; b=aGZRNPB9i1T5v1LnyERWcXsuHPaSVWOIfPQnazAlwIR+quNxw7UP0iCkYsm3ivAxQU xARoJTwrORQq/rGiJPtbohU3L2ghHnyKcZlrzUDyxBQmr9pWUuUJoNVzZ9A7PB6qm4ai dAqKhTk506ksOoYAX+ziyd4EaXEFaDn+hft6pYzHeD0WmDwV2sz3qMlEAE5i5XtO3v/m hVG/wxf/ghAJlvn+RXwlI0+Fx5LJFsBWIIIhgrkOgSC+3fF0rOMPl5J43ndvL9d4Ls0i Wwk6SvK5rrgv+1GCaXs0A8ipj51tdk+WoVj2OgW0VhURFPRC0zzMVVQOHgbCZ6+OHdN0 yTyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BTSmYzl0sYL6U3pEfv9/5A9umdXLofLexJIK/i1h5Zk=; b=YNh/jgFpD0pS16HLnKEVClQq+bmEQu03YL41RpKC2JWncrUnZRZ2PXaJkYP0KVGYr/ o7Lz7CVXkg1WqnG+nBF3fytG6udiDxAsJ/RVKOH4sT6lFVhRx6Eqkicrrd9Y3a44JHke 7oepHiJpiFkRobdIJcSUL23g0P1fixL0WNadCgcSrfC/VW9hQk7wdZnVBj5mQkxkz7CQ 4agR8RRylEZZ+3yNLgUvqAcuaorz/RmayixwYV4MEx9tCaTIQUH+2uXj7qfpEFfI0PoD xMAZRVW5I8fyJjWG5hOXcpVM2ys8CPJEazWUjw/okyW7CDj3cfDgkS7hqsoTl40hzkrJ kV/Q== X-Gm-Message-State: AOAM532VUo8LrAwOXuzLfx5uUlk14DtBQCwUhdUMMiiHhI+0Tq8QXZGs FUOCkxt2AqGGZdzxnyaqRxpJtQ== X-Google-Smtp-Source: ABdhPJzg39hrdEwl0SueoJk3pC6SZFmLPibg9kpsLtvX6G59lOrG9wELtpVVx7TyjNNjt53J1zXgMQ== X-Received: by 2002:a17:90a:7045:: with SMTP id f63mr24626608pjk.35.1618160656008; Sun, 11 Apr 2021 10:04:16 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id x20sm8395692pjp.12.2021.04.11.10.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Apr 2021 10:04:15 -0700 (PDT) Date: Sun, 11 Apr 2021 10:04:11 -0700 From: Stephen Hemminger To: Ansuel Smith Cc: netdev@vger.kernel.org, Marek =?UTF-8?B?QmVow7pu?= , David Ahern , "David S. Miller" , Jakub Kicinski , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eric Dumazet , Wei Wang , Cong Wang , Taehee Yoo , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Di Zhu , Weilong Chen , Nikolay Aleksandrov , Colin Ian King , Roopa Prabhu , Francis Laniel , linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC iproute2-next] iplink: allow to change iplink value Message-ID: <20210411100411.6d16e51d@hermes.local> In-Reply-To: <20210410133454.4768-5-ansuelsmth@gmail.com> References: <20210410133454.4768-1-ansuelsmth@gmail.com> <20210410133454.4768-5-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Apr 2021 15:34:50 +0200 Ansuel Smith wrote: > Allow to change the interface to which a given interface is linked to. > This is useful in the case of multi-CPU port DSA, for changing the CPU > port of a given user port. >=20 > Signed-off-by: Marek Beh=C3=BAn > Cc: David Ahern > Cc: Stephen Hemminger This may work for DSA but it won't work for all the device types vlan/macse= c/... that now use the link attribute. It looks like the change link handling for tho= se device types just ignores the link attribute (maybe ok). But before support= ing this as an API, it would be better if all the other drivers that use IFLA_LINK had error checks in their change link handling. Please add error checks in kernel first.