From: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: [PATCH] staging: media: omap4iss: Replace macro function by static inline function in file iss_csi2.c
Date: Mon, 12 Apr 2021 10:36:34 -0300 [thread overview]
Message-ID: <20210412133634.GA1791@focaruja> (raw)
Replace macro function by static inline function.
Issue suggested by Julia.
Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
---
drivers/staging/media/omap4iss/iss_csi2.c | 49 ++++++++++++++++---------------
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_csi2.c b/drivers/staging/media/omap4iss/iss_csi2.c
index a6dc2d2..cbeba44 100644
--- a/drivers/staging/media/omap4iss/iss_csi2.c
+++ b/drivers/staging/media/omap4iss/iss_csi2.c
@@ -597,9 +597,12 @@ static int csi2_configure(struct iss_csi2_device *csi2)
/*
* csi2_print_status - Prints CSI2 debug information.
*/
-#define CSI2_PRINT_REGISTER(iss, regs, name)\
- dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n", \
- iss_reg_read(iss, regs, CSI2_##name))
+static inline csi2_print_register(iss, regs, name)
+{
+ dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
+ iss_reg_read(iss, regs, CSI2_##name));
+}
+
static void csi2_print_status(struct iss_csi2_device *csi2)
{
@@ -610,26 +613,26 @@ static void csi2_print_status(struct iss_csi2_device *csi2)
dev_dbg(iss->dev, "-------------CSI2 Register dump-------------\n");
- CSI2_PRINT_REGISTER(iss, csi2->regs1, SYSCONFIG);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, SYSSTATUS);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, IRQENABLE);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, IRQSTATUS);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTRL);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, DBG_H);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, COMPLEXIO_CFG);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, COMPLEXIO_IRQSTATUS);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, SHORT_PACKET);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, COMPLEXIO_IRQENABLE);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, DBG_P);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, TIMING);
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_CTRL1(0));
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_CTRL2(0));
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_DAT_OFST(0));
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_PING_ADDR(0));
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_PONG_ADDR(0));
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_IRQENABLE(0));
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_IRQSTATUS(0));
- CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_CTRL3(0));
+ csi2_print_register(iss, csi2->regs1, SYSCONFIG);
+ csi2_print_register(iss, csi2->regs1, SYSSTATUS);
+ csi2_print_register(iss, csi2->regs1, IRQENABLE);
+ csi2_print_register(iss, csi2->regs1, IRQSTATUS);
+ csi2_print_register(iss, csi2->regs1, CTRL);
+ csi2_print_register(iss, csi2->regs1, DBG_H);
+ csi2_print_register(iss, csi2->regs1, COMPLEXIO_CFG);
+ csi2_print_register(iss, csi2->regs1, COMPLEXIO_IRQSTATUS);
+ csi2_print_register(iss, csi2->regs1, SHORT_PACKET);
+ csi2_print_register(iss, csi2->regs1, COMPLEXIO_IRQENABLE);
+ csi2_print_register(iss, csi2->regs1, DBG_P);
+ csi2_print_register(iss, csi2->regs1, TIMING);
+ csi2_print_register(iss, csi2->regs1, CTX_CTRL1(0));
+ csi2_print_register(iss, csi2->regs1, CTX_CTRL2(0));
+ csi2_print_register(iss, csi2->regs1, CTX_DAT_OFST(0));
+ csi2_print_register(iss, csi2->regs1, CTX_PING_ADDR(0));
+ csi2_print_register(iss, csi2->regs1, CTX_PONG_ADDR(0));
+ csi2_print_register(iss, csi2->regs1, CTX_IRQENABLE(0));
+ csi2_print_register(iss, csi2->regs1, CTX_IRQSTATUS(0));
+ csi2_print_register(iss, csi2->regs1, CTX_CTRL3(0));
dev_dbg(iss->dev, "--------------------------------------------\n");
}
--
2.7.4
next reply other threads:[~2021-04-12 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:36 Aline Santana Cordeiro [this message]
2021-04-12 16:46 ` [PATCH] staging: media: omap4iss: Replace macro function by static inline function in file iss_csi2.c kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412133634.GA1791@focaruja \
--to=alinesantanacordeiro@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).