From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5536EC433B4 for ; Mon, 12 Apr 2021 16:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 324FB6139C for ; Mon, 12 Apr 2021 16:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244328AbhDLQZl (ORCPT ); Mon, 12 Apr 2021 12:25:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:55508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243513AbhDLQXy (ORCPT ); Mon, 12 Apr 2021 12:23:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 738E761357; Mon, 12 Apr 2021 16:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618244614; bh=hD5+h9rx/iTLDFNOKaU/RhNebTCrLUD67CNBZP7/j4M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kT2De4QOMrTeGlDKTuXGSuwFK3vcCumUcMBhHIZY81hxVhaiLbSKkIlW/0r/5nIk8 75NpOK4GPCPsRtiqVqHQvn7gVDzzudQf0MxGXV7/xrotZvR36nuAMhBqf5gVOD7V3Y mZgi3ByagTGaG4zXJpOS7k3ju2Zvm3p9vaeIOGmivAsOW/7c8a1ubAKdOqvpkEiFre BxCmDE6gphvsJZ57ig4FAeneVLi2HQeMbGvQHQbsnk0/naUnoC/tlhZ4p1NSuC1Ivv stxsFXesULFVuU2ahTU76tLjiI2a4omHOhadgQVtac1JYQFAPbecncMHFtmZ0615GG /0AN7rBZtQxHw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Aring , Stefan Schmidt , Sasha Levin , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.11 30/51] net: ieee802154: forbid monitor for add llsec key Date: Mon, 12 Apr 2021 12:22:35 -0400 Message-Id: <20210412162256.313524-30-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210412162256.313524-1-sashal@kernel.org> References: <20210412162256.313524-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring [ Upstream commit 08470c5453339369bd3d590c4cbb0b5961cdcbb6 ] This patch forbids to add llsec key for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210405003054.256017-5-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index c85e4230ec60..c10fc3479d3e 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1552,6 +1552,9 @@ static int nl802154_add_llsec_key(struct sk_buff *skb, struct genl_info *info) struct ieee802154_llsec_key_id id = { }; u32 commands[NL802154_CMD_FRAME_NR_IDS / 32] = { }; + if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR) + return -EOPNOTSUPP; + if (!info->attrs[NL802154_ATTR_SEC_KEY] || nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack)) return -EINVAL; -- 2.30.2