From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04CCAC070DE for ; Mon, 12 Apr 2021 16:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D546B61371 for ; Mon, 12 Apr 2021 16:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345650AbhDLQrl (ORCPT ); Mon, 12 Apr 2021 12:47:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:38886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344116AbhDLQh4 (ORCPT ); Mon, 12 Apr 2021 12:37:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B7E7613E3; Mon, 12 Apr 2021 16:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618244879; bh=2uYjanq6QfJ2aujagHmihTIaSEqkN/qmiryg2XX/cWQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rR++mzr4nTE7Gk0IlFFFfQYGK5+Kh1gj841auvIf0u4rBHQk9MkBSNia3zvTE/pJP xbLCfxAgzPue4BKr2x7AUn8vqgJ2P6QfjitJurbZl4dQE0iA4yu2KVy8OvHsW6LGqL jgxlidHlSv6rcwteD0ja7836QJaQVsjbUmEXwWGD4B/t556+uYXUCsahCN1Vx73EjG 8I/rhOmfF40qqBiKUB3rm0MzE0zRm+eD0Cxpu/a5cXOs8FLhgFDCtmWBnfnu0D+1WY 3IfeuZYKtdrxFDiBPMU6hG9EiWavANzoaB8y+XET/Ko3cs6XaQtbvURo89fpLNV9c8 e2HK4MZVdK1+Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Aring , syzbot+fbf4fc11a819824e027b@syzkaller.appspotmail.com, Stefan Schmidt , Sasha Levin , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 17/23] net: ieee802154: forbid monitor for del llsec seclevel Date: Mon, 12 Apr 2021 12:27:30 -0400 Message-Id: <20210412162736.316026-17-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210412162736.316026-1-sashal@kernel.org> References: <20210412162736.316026-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring [ Upstream commit 9dde130937e95b72adfae64ab21d6e7e707e2dac ] This patch forbids to del llsec seclevel for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Reported-by: syzbot+fbf4fc11a819824e027b@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210405003054.256017-15-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index 8173f9d2492b..f0de6ea84124 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -2112,6 +2112,9 @@ static int nl802154_del_llsec_seclevel(struct sk_buff *skb, struct wpan_dev *wpan_dev = dev->ieee802154_ptr; struct ieee802154_llsec_seclevel sl; + if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR) + return -EOPNOTSUPP; + if (!info->attrs[NL802154_ATTR_SEC_LEVEL] || llsec_parse_seclevel(info->attrs[NL802154_ATTR_SEC_LEVEL], &sl) < 0) -- 2.30.2