From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F027FC4361B for ; Mon, 12 Apr 2021 16:36:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA5DC61363 for ; Mon, 12 Apr 2021 16:36:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245652AbhDLQe5 (ORCPT ); Mon, 12 Apr 2021 12:34:57 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:49697 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243998AbhDLQ20 (ORCPT ); Mon, 12 Apr 2021 12:28:26 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVzPw-00086R-Sy; Mon, 12 Apr 2021 16:28:04 +0000 From: Colin King To: "Michael S . Tsirkin" , Jason Wang , Parav Pandit , virtualization@lists.linux-foundation.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] vdpa/mlx5: Fix resource leak of mgtdev due to incorrect kfree Date: Mon, 12 Apr 2021 17:28:04 +0100 Message-Id: <20210412162804.1628738-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Static analysis is reporting a memory leak on mgtdev, it appears that the wrong object is being kfree'd. Fix this by kfree'ing mgtdev rather than mdev. Addresses-Coverity: ("Resource leak") Fixes: c8a2d4c73e70 ("vdpa/mlx5: Enable user to add/delete vdpa device") Signed-off-by: Colin Ian King --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 10c5fef3c020..25533db01f5f 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -2089,7 +2089,7 @@ static int mlx5v_probe(struct auxiliary_device *adev, return 0; reg_err: - kfree(mdev); + kfree(mgtdev); return err; } -- 2.30.2