From: Steven Lee <steven_lee@aspeedtech.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Rob Herring <robh+dt@kernel.org>, "Joel Stanley" <joel@jms.id.au>,
Adrian Hunter <adrian.hunter@intel.com>,
Ryan Chen <ryanchen.aspeed@gmail.com>,
"moderated list:ASPEED SD/MMC DRIVER"
<linux-aspeed@lists.ozlabs.org>,
"moderated list:ASPEED SD/MMC DRIVER" <openbmc@lists.ozlabs.org>,
"open list:ASPEED SD/MMC DRIVER" <linux-mmc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Subject: Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-of-aspeed: Add power-gpio and power-switch-gpio
Date: Tue, 13 Apr 2021 11:31:56 +0800 [thread overview]
Message-ID: <20210413033155.GA3522@aspeedtech.com> (raw)
In-Reply-To: <CAPDyKFr=Gtwu4v22FBaax5EjRbXTNez1N2ZQxP=v0LKGFTCovw@mail.gmail.com>
The 04/12/2021 15:38, Ulf Hansson wrote:
> On Thu, 8 Apr 2021 at 03:52, Steven Lee <steven_lee@aspeedtech.com> wrote:
> >
> > AST2600-A2 EVB provides the reference design for enabling SD bus power
> > and toggling SD bus signal voltage by GPIO pins.
> > Add the definition and example for power-gpio and power-switch-gpio
> > properties.
> >
> > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to power
> > load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is connected to
> > a 1.8v and a 3.3v power load switch that providing signal voltage to
> > SD1 bus.
> > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is
> > disabled.
> > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 signal
> > voltage is 3.3v. Otherwise, 1.8v power load switch will be enabled, SD1
> > signal voltage becomes 1.8v.
> >
> > AST2600-A2 EVB also support toggling signal voltage for SD2 bus.
> > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and GPIOV3
> > as power-switch-gpio.
>
> Thanks for sharing the details, it certainly helps while reviewing.
>
> >
> > Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
> > ---
> > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > index 987b287f3bff..515a74614f3c 100644
> > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > @@ -37,6 +37,14 @@ properties:
> > clocks:
> > maxItems: 1
> > description: The SD/SDIO controller clock gate
> > + power-gpio:
> > + description:
> > + The GPIO for enabling/disabling SD bus power.
> > + maxItems: 1
> > + power-switch-gpio:
> > + description:
> > + The GPIO for toggling the signal voltage between 3.3v and 1.8v.
> > + maxItems: 1
>
>
> >
> > patternProperties:
> > "^sdhci@[0-9a-f]+$":
> > @@ -61,6 +69,14 @@ patternProperties:
> > sdhci,auto-cmd12:
> > type: boolean
> > description: Specifies that controller should use auto CMD12
> > + power-gpio:
> > + description:
> > + The GPIO for enabling/disabling SD bus power.
> > + maxItems: 1
> > + power-switch-gpio:
> > + description:
> > + The GPIO for toggling the signal voltage between 3.3v and 1.8v.
> > + maxItems: 1
> > required:
>
> Please do not model these as GPIO pins like this. Instead, it's better
> to model them as gpio regulators, since the mmc core manages them as
> regulators.
>
> We have a vmmc regulator (corresponding to vdd) and a vqmmc regulator
> (corresponding the signal-voltage level). These are also described in
> the common mmc DT bindings, see
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml.
>
Thanks for the information. I will modify it.
> > - compatible
> > - reg
> > @@ -80,6 +96,7 @@ required:
> > examples:
> > - |
> > #include <dt-bindings/clock/aspeed-clock.h>
> > + #include <dt-bindings/gpio/aspeed-gpio.h>
> > sdc@1e740000 {
> > compatible = "aspeed,ast2500-sd-controller";
> > reg = <0x1e740000 0x100>;
> > @@ -94,6 +111,10 @@ examples:
> > interrupts = <26>;
> > sdhci,auto-cmd12;
> > clocks = <&syscon ASPEED_CLK_SDIO>;
> > + power-gpio = <&gpio0 ASPEED_GPIO(V, 0)
> > + GPIO_ACTIVE_HIGH>;
> > + power-switch-gpio = <&gpio0 ASPEED_GPIO(V, 1)
> > + GPIO_ACTIVE_HIGH>;
> > };
> >
> > sdhci1: sdhci@200 {
> > @@ -102,5 +123,9 @@ examples:
> > interrupts = <26>;
> > sdhci,auto-cmd12;
> > clocks = <&syscon ASPEED_CLK_SDIO>;
> > + power-gpio = <&gpio0 ASPEED_GPIO(V, 2)
> > + GPIO_ACTIVE_HIGH>;
> > + power-switch-gpio = <&gpio0 ASPEED_GPIO(V, 3)
> > + GPIO_ACTIVE_HIGH>;
> > };
> > };
>
> Kind regards
> Uffe
next prev parent reply other threads:[~2021-04-13 3:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 1:52 [PATCH v1 0/2] mmc: sdhci-of-aspeed: Support toggling SD bus signal Steven Lee
2021-04-08 1:52 ` [PATCH v1 1/2] dt-bindings: mmc: sdhci-of-aspeed: Add power-gpio and power-switch-gpio Steven Lee
2021-04-09 18:41 ` Rob Herring
2021-04-13 1:30 ` Steven Lee
2021-04-13 2:43 ` Milton Miller II
2021-04-13 3:38 ` Steven Lee
2021-04-12 7:38 ` Ulf Hansson
2021-04-13 3:31 ` Steven Lee [this message]
2021-04-08 1:52 ` [PATCH v1 2/2] mmc: sdhci-of-aspeed: Support toggling SD bus signal voltage by GPIO Steven Lee
2021-04-09 4:14 ` Andrew Jeffery
2021-04-12 6:50 ` Steven Lee
2021-04-12 23:18 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413033155.GA3522@aspeedtech.com \
--to=steven_lee@aspeedtech.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=ryanchen.aspeed@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).