From: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Subject: [PATCH 4/8] MIPS: pci-rt3883: more accurate DT error messages
Date: Mon, 12 Apr 2021 23:21:42 -0700 [thread overview]
Message-ID: <20210413062146.389690-5-ilya.lipnitskiy@gmail.com> (raw)
In-Reply-To: <20210413062146.389690-1-ilya.lipnitskiy@gmail.com>
Existing strings do not make sense: one is always NULL and the other
refers to the wrong parent node.
Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
---
arch/mips/pci/pci-rt3883.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c
index e422f78db5bc..aebd4964ea34 100644
--- a/arch/mips/pci/pci-rt3883.c
+++ b/arch/mips/pci/pci-rt3883.c
@@ -431,8 +431,7 @@ static int rt3883_pci_probe(struct platform_device *pdev)
if (!rpc->intc_of_node) {
dev_err(dev, "%pOF has no %s child node",
- rpc->intc_of_node,
- "interrupt controller");
+ np, "interrupt controller");
return -EINVAL;
}
@@ -446,8 +445,7 @@ static int rt3883_pci_probe(struct platform_device *pdev)
if (!rpc->pci_controller.of_node) {
dev_err(dev, "%pOF has no %s child node",
- rpc->intc_of_node,
- "PCI host bridge");
+ np, "PCI host bridge");
err = -EINVAL;
goto err_put_intc_node;
}
--
2.31.1
next prev parent reply other threads:[~2021-04-13 6:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 6:21 [PATCH 0/8] MIPS: Fixes for PCI legacy drivers (rt2880, rt3883) Ilya Lipnitskiy
2021-04-13 6:21 ` [PATCH 1/8] MIPS: pci-rt2880: fix slot 0 configuration Ilya Lipnitskiy
2021-04-13 6:21 ` [PATCH 2/8] MIPS: pci-rt2880: remove unneeded locks Ilya Lipnitskiy
2021-04-13 13:28 ` Sergey Ryazanov
2021-04-13 13:40 ` Sergey Ryazanov
2021-04-13 16:48 ` Ilya Lipnitskiy
2021-04-13 6:21 ` [PATCH 3/8] MIPS: pci-rt3883: trivial: remove unused variable Ilya Lipnitskiy
2021-04-13 12:50 ` Sergey Ryazanov
2021-04-13 6:21 ` Ilya Lipnitskiy [this message]
2021-04-13 6:21 ` [PATCH 5/8] MIPS: pci-legacy: stop using of_pci_range_to_resource Ilya Lipnitskiy
2021-04-13 6:21 ` [PATCH 6/8] MIPS: pci-legacy: remove redundant info messages Ilya Lipnitskiy
2021-04-13 6:21 ` [PATCH 7/8] MIPS: pci-legacy: remove busn_resource field Ilya Lipnitskiy
2021-04-13 6:21 ` [PATCH 8/8] MIPS: pci-legacy: use generic pci_enable_resources Ilya Lipnitskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413062146.389690-5-ilya.lipnitskiy@gmail.com \
--to=ilya.lipnitskiy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).