From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D03CC43460 for ; Tue, 13 Apr 2021 07:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1244F6109F for ; Tue, 13 Apr 2021 07:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237870AbhDMHpi (ORCPT ); Tue, 13 Apr 2021 03:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237080AbhDMHph (ORCPT ); Tue, 13 Apr 2021 03:45:37 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5802C061574 for ; Tue, 13 Apr 2021 00:45:16 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id n38so10910279pfv.2 for ; Tue, 13 Apr 2021 00:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QARXMbXYkHRFs98oMdNLg8h+WFH6ZlQGms74fZMVOkQ=; b=repmRSmvMl/bvfpmMoyAkDWLo9vhTDm8lUUzc4GCn366TLIpG4a2qO/UM9qD1r1DI+ mx8LBF9x7XLsGuyWjbc8tjA3DY2SwbjiU2sxBFSZGQm9EixikJFNhpET/jQ0099S3ejK SFVHAR0ni/NIu2dC/xVWN0Y4lmEFWBDU3YgciCftYlXY3RRYFIIRQx+DaRqyyX6tg5W+ JfMTolNSQRoScMZ94dRKkSK5HvdUYfNgpBo/tXAc832geGin+NMsq07vKfJeczfX+R+f 3ZdvyV1ziRo/Un2YYSE8tAKFbcxuFmwZbKZ10OyTixEz7WPvNHfOi0SysrrASvSahcOn ksiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QARXMbXYkHRFs98oMdNLg8h+WFH6ZlQGms74fZMVOkQ=; b=VX38BZ0PPIXSLEYRLyOcc9gfv/wIWRmoqeqyKRgl5Ka8j2IElglA4BFPN7WpiUmqUs ZATrTY9fLc9TMHe6AxL1p+Oi6yUR6MPBBwX76Ye1MFiWlZAgk7nmAkeRMdJ2jWwGP+ZF +LcjgTowUs8Lm479tGDLrJ4/wNOwVPxd87kfkLjJpMgJYijUvlABobP3Vx2UVKzTdpNM 6/P6P2ACQujscEg5wi808qfJBFIn0ET6grTOQ7Aj4vbbShSl49eIqYWkllTaPe8pGoky 6UCjoZPnSwlF0TznhZOqf9CfpqjH2m8zVskWTSeqL2hLDAFkDrkCiLEsxDpkWrrAQTe+ wCFA== X-Gm-Message-State: AOAM5301zAnsF8M1MMuzrOsL0aUoAUIr96aUu8UHarKKax4ASYsEOFKH RU4j2buQQgV9he3aMVqNucdKeg== X-Google-Smtp-Source: ABdhPJyjRQTjpRuCwjYQYXkq36SzIUgnE7pTkacJBg1IsA6ULGM5LIg1fUqjDRH8fRYq47xVc0U++w== X-Received: by 2002:a63:1203:: with SMTP id h3mr31126771pgl.223.1618299916375; Tue, 13 Apr 2021 00:45:16 -0700 (PDT) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id 23sm13612618pgo.53.2021.04.13.00.45.13 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Apr 2021 00:45:16 -0700 (PDT) Date: Tue, 13 Apr 2021 15:45:09 +0800 From: Shawn Guo To: Arend van Spriel Cc: Kalle Valo , Rob Herring , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Subject: Re: [PATCH 2/2] brcmfmac: support parse country code map from DT Message-ID: <20210413074509.GD15093@dragon> References: <20210408113022.18180-1-shawn.guo@linaro.org> <20210408113022.18180-3-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 10:09:38AM +0200, Arend van Spriel wrote: > On 08-04-2021 13:30, Shawn Guo wrote: > > With any regulatory domain requests coming from either user space or > > 802.11 IE (Information Element), the country is coded in ISO3166 > > standard. It needs to be translated to firmware country code and > > revision with the mapping info in settings->country_codes table. > > Support populate country_codes table by parsing the mapping from DT. > > comment below, but you may add... > > Reviewed-by: Arend van Spriel Thanks for reviewing, Arend. > > Signed-off-by: Shawn Guo > > --- > > .../wireless/broadcom/brcm80211/brcmfmac/of.c | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c > > index a7554265f95f..ea5c7f434c2c 100644 > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c > > [...] > > > @@ -47,6 +96,10 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, > > !of_device_is_compatible(np, "brcm,bcm4329-fmac")) > > return; > > + ret = brcmf_of_get_country_codes(dev, settings); > > + if (ret) > > + dev_warn(dev, "failed to get OF country code map\n"); > > First of all I prefer to use brcmf_err and add ret value to the print > message " (err=%d)\n". Okay. > Another thing is that this mapping is not only > applicable for SDIO devices so you may consider doing this for other bus > types as well which requires a bit more rework here. Right. I will take care of it, if we can convince Kalle that having this data in DT is not such a bad idea. Shawn