From: Ismael Luceno <ismael@iodev.co.uk>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: maintainers@bluecherrydvr.com, anton@corp.bluecherry.net,
andrey_utkin@fastmail.com, mchehab@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: solo6x10: remove useless function
Date: Tue, 13 Apr 2021 12:02:28 +0200 [thread overview]
Message-ID: <20210413100228.GC27272@pirotess> (raw)
In-Reply-To: <1618298581-33566-1-git-send-email-jiapeng.chong@linux.alibaba.com>
NACK; before removing any of these functions the fields should be
documented somewhere else, so that no information is lost.
On 13/Apr/2021 15:23, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c:394:19: warning: unused
> function 'vop_interlaced' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> index 0abcad4..8c4fae7 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> @@ -391,11 +391,6 @@ static int solo_send_desc(struct solo_enc_dev *solo_enc, int skip,
> }
>
> /* Extract values from VOP header - VE_STATUSxx */
> -static inline int vop_interlaced(const vop_header *vh)
> -{
> - return (__le32_to_cpu((*vh)[0]) >> 30) & 1;
> -}
> -
> static inline u8 vop_channel(const vop_header *vh)
> {
> return (__le32_to_cpu((*vh)[0]) >> 24) & 0x1F;
> --
> 1.8.3.1
>
--
Ismael Luceno
http://iodev.co.uk/
prev parent reply other threads:[~2021-04-13 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 7:23 [PATCH] media: solo6x10: remove useless function Jiapeng Chong
2021-04-13 10:02 ` Ismael Luceno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413100228.GC27272@pirotess \
--to=ismael@iodev.co.uk \
--cc=andrey_utkin@fastmail.com \
--cc=anton@corp.bluecherry.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).