From: Eugen Hristev <eugen.hristev@microchip.com>
To: <devicetree@vger.kernel.org>, <linux-media@vger.kernel.org>,
<jacopo@jmondi.org>, <robh+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Eugen Hristev <eugen.hristev@microchip.com>
Subject: [PATCH v3 21/33] media: atmel: atmel-isc: create callback for DPC submodule product specific
Date: Tue, 13 Apr 2021 13:57:19 +0300 [thread overview]
Message-ID: <20210413105731.610028-22-eugen.hristev@microchip.com> (raw)
In-Reply-To: <20210413105731.610028-1-eugen.hristev@microchip.com>
The DPC submodule is a part of the atmel-isc pipeline, and stands for
Defective Pixel Correction. Its purpose is to detect defective pixels and
correct them if possible with the help of adjacent pixels.
Create a product specific callback for initializing the DPC submodule
of the pipeline.
For sama5d2 product, this module does not exist, thus this function is a noop.
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
Changes in v3:
- added module description in commit message
Changes in v2:
- addded function prototype to avoid warning with W=1
drivers/media/platform/atmel/atmel-isc-base.c | 1 +
drivers/media/platform/atmel/atmel-isc.h | 3 +++
drivers/media/platform/atmel/atmel-sama5d2-isc.c | 7 +++++++
3 files changed, 11 insertions(+)
diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c
index 69952b6ac401..1f7116abc61a 100644
--- a/drivers/media/platform/atmel/atmel-isc-base.c
+++ b/drivers/media/platform/atmel/atmel-isc-base.c
@@ -651,6 +651,7 @@ static void isc_set_pipeline(struct isc_device *isc, u32 pipeline)
regmap_bulk_write(regmap, ISC_GAM_GENTRY, gamma, GAMMA_ENTRIES);
regmap_bulk_write(regmap, ISC_GAM_RENTRY, gamma, GAMMA_ENTRIES);
+ isc->config_dpc(isc);
isc->config_csc(isc);
isc->config_cbc(isc);
isc->config_cc(isc);
diff --git a/drivers/media/platform/atmel/atmel-isc.h b/drivers/media/platform/atmel/atmel-isc.h
index eb549fadb1a8..d6cd85a4c3e9 100644
--- a/drivers/media/platform/atmel/atmel-isc.h
+++ b/drivers/media/platform/atmel/atmel-isc.h
@@ -221,6 +221,8 @@ struct isc_reg_offsets {
* @max_width: maximum frame width, dependent on the internal RAM
* @max_height: maximum frame height, dependent on the internal RAM
*
+ * @config_dpc: pointer to a function that initializes product
+ * specific DPC module
* @config_csc: pointer to a function that initializes product
* specific CSC module
* @config_cbc: pointer to a function that initializes product
@@ -300,6 +302,7 @@ struct isc_device {
u32 max_height;
struct {
+ void (*config_dpc)(struct isc_device *isc);
void (*config_csc)(struct isc_device *isc);
void (*config_cbc)(struct isc_device *isc);
void (*config_cc)(struct isc_device *isc);
diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
index 7ff8b362568d..2b53e9427353 100644
--- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
+++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
@@ -57,6 +57,7 @@
void isc_sama5d2_config_csc(struct isc_device *isc);
void isc_sama5d2_config_cbc(struct isc_device *isc);
void isc_sama5d2_config_cc(struct isc_device *isc);
+void isc_sama5d2_config_dpc(struct isc_device *isc);
void isc_sama5d2_config_ctrls(struct isc_device *isc,
const struct v4l2_ctrl_ops *ops);
@@ -114,6 +115,11 @@ void isc_sama5d2_config_ctrls(struct isc_device *isc,
v4l2_ctrl_new_std(hdl, ops, V4L2_CID_CONTRAST, -2048, 2047, 1, 256);
}
+void isc_sama5d2_config_dpc(struct isc_device *isc)
+{
+ /* This module is not present on sama5d2 pipeline */
+}
+
/* Gamma table with gamma 1/2.2 */
const u32 isc_sama5d2_gamma_table[][GAMMA_ENTRIES] = {
/* 0 --> gamma 1/1.8 */
@@ -259,6 +265,7 @@ static int atmel_isc_probe(struct platform_device *pdev)
isc->max_width = ISC_SAMA5D2_MAX_SUPPORT_WIDTH;
isc->max_height = ISC_SAMA5D2_MAX_SUPPORT_HEIGHT;
+ isc->config_dpc = isc_sama5d2_config_dpc;
isc->config_csc = isc_sama5d2_config_csc;
isc->config_cbc = isc_sama5d2_config_cbc;
isc->config_cc = isc_sama5d2_config_cc;
--
2.25.1
next prev parent reply other threads:[~2021-04-13 11:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 10:56 [PATCH v3 00/33] media: atmel: atmel-isc: add support for xisc Eugen Hristev
2021-04-13 10:56 ` [PATCH v3 01/33] media: atmel: atmel-isc: specialize gamma table into product specific Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 02/33] media: atmel: atmel-isc: specialize driver name constant Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 03/33] media: atmel: atmel-isc: add checks for limiting frame sizes Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 04/33] media: atmel: atmel-isc: specialize max width and max height Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 05/33] media: atmel: atmel-isc: specialize dma cfg Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 06/33] media: atmel: atmel-isc: extract CSC submodule config into separate function Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 07/33] media: atmel: atmel-isc-base: add id to clock debug message Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 08/33] media: atmel: atmel-isc: create register offsets struct Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 09/33] media: atmel: atmel-isc: extract CBC submodule config into separate function Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 10/33] media: atmel: atmel-isc: add CBC to the reg offsets struct Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 11/33] media: atmel: atmel-isc: add SUB422 and SUB420 to register offsets Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 12/33] media: atmel: atmel-isc: add RLP " Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 13/33] media: atmel: atmel-isc: add HIS " Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 14/33] media: atmel: atmel-isc: add DMA " Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 15/33] media: atmel: atmel-isc: add support for version register Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 16/33] media: atmel: atmel-isc: add his_entry to register offsets Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 17/33] media: atmel: atmel-isc: add register description for additional modules Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 18/33] media: atmel: atmel-isc: extend pipeline with extra modules Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 19/33] media: atmel: atmel-isc: add CC initialization function Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 20/33] media: atmel: atmel-isc: create product specific v4l2 controls config Eugen Hristev
2021-04-13 10:57 ` Eugen Hristev [this message]
2021-04-13 10:57 ` [PATCH v3 22/33] media: atmel: atmel-isc: create callback for GAM submodule product specific Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 23/33] media: atmel: atmel-isc: create callback for RLP " Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 24/33] media: atmel: atmel-isc: move the formats list into product specific code Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 25/33] media: atmel: atmel-isc: create an adapt pipeline callback for product specific Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 26/33] media: atmel: atmel-isc-regs: add additional fields for sama7g5 type pipeline Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 27/33] media: atmel: atmel-isc-base: add support for more formats and additional pipeline modules Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 28/33] media: atmel: atmel-isc-sama5d2: remove duplicate define Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 29/33] dt-bindings: media: atmel-isc: convert to yaml Eugen Hristev
2021-04-13 16:32 ` Rob Herring
2021-04-15 8:55 ` [PATCH v4 " Eugen Hristev
2021-04-15 16:16 ` Rob Herring
2021-04-13 10:57 ` [PATCH v3 30/33] dt-bindings: media: add microchip,xisc device bindings Eugen Hristev
2021-04-13 16:34 ` Rob Herring
2021-04-15 8:58 ` [PATCH v4 " Eugen Hristev
2021-04-15 16:40 ` Rob Herring
2021-04-15 18:45 ` [PATCH v5 " Eugen Hristev
2021-04-16 19:06 ` [PATCH v5 30/33] dt-bindings: media: add microchip, xisc " Rob Herring
2021-04-13 10:57 ` [PATCH v3 31/33] media: atmel: atmel-isc: add microchip-xisc driver Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 32/33] MAINTAINERS: update ISC driver bindings file Eugen Hristev
2021-04-13 10:57 ` [PATCH v3 33/33] MAINTAINERS: add xisc files to isc driver entry Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413105731.610028-22-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).