From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B08C433ED for ; Tue, 13 Apr 2021 12:28:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AAA161278 for ; Tue, 13 Apr 2021 12:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345892AbhDMM25 (ORCPT ); Tue, 13 Apr 2021 08:28:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42217 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345701AbhDMM2A (ORCPT ); Tue, 13 Apr 2021 08:28:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618316859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FGtFF7jhsw/ykKn6fZnKyKnXNxaVpoMQNCbt41jAeMY=; b=KK+N6BLrgmhXhVxBhcXv3ag7FaLDDBEy1iXojUv50kQ7do+EIdpLz6NGnqY7bCbyf4E06Q bW9KBxZLYmxg6AKJCzFAiLST359GrgiO1n4Jm/TKVaTBpBg6bkQXI3asK9Awd3uyd5OqS5 GYmhmDDjG8LU2a8RC/0jZrUls1O0we0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-5wGFQlaKM-K3Pf80d4lldw-1; Tue, 13 Apr 2021 08:27:38 -0400 X-MC-Unique: 5wGFQlaKM-K3Pf80d4lldw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C3A419611AD; Tue, 13 Apr 2021 12:27:37 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.195.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id B21A017BB6; Tue, 13 Apr 2021 12:27:32 +0000 (UTC) From: Vitaly Kuznetsov To: kvm@vger.kernel.org, Paolo Bonzini Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Siddharth Chandrasekaran , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: [PATCH RFC 17/22] KVM: x86: hyper-v: Honor HV_POST_MESSAGES privilege bit Date: Tue, 13 Apr 2021 14:26:25 +0200 Message-Id: <20210413122630.975617-18-vkuznets@redhat.com> In-Reply-To: <20210413122630.975617-1-vkuznets@redhat.com> References: <20210413122630.975617-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hyper-V partition must possess 'HV_POST_MESSAGES' privilege to issue HVCALL_POST_MESSAGE hypercalls. Signed-off-by: Vitaly Kuznetsov --- arch/x86/kvm/hyperv.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c index 0df18187d908..6e4bf1da9dcf 100644 --- a/arch/x86/kvm/hyperv.c +++ b/arch/x86/kvm/hyperv.c @@ -2073,12 +2073,16 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu) u64 param, ingpa, outgpa, ret = HV_STATUS_SUCCESS; uint16_t code, rep_idx, rep_cnt; bool fast, rep; + struct kvm_vcpu_hv *hv_vcpu = to_hv_vcpu(vcpu); /* * hypercall generates UD from non zero cpl and real mode - * per HYPER-V spec + * per HYPER-V spec. Fail the call when 'hv_vcpu' context + * was not allocated (e.g. per-vCPU Hyper-V CPUID entries + * are unset) as well. */ - if (static_call(kvm_x86_get_cpl)(vcpu) != 0 || !is_protmode(vcpu)) { + if (static_call(kvm_x86_get_cpl)(vcpu) != 0 || !is_protmode(vcpu) || + !hv_vcpu) { kvm_queue_exception(vcpu, UD_VECTOR); return 1; } @@ -2125,6 +2129,12 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu) break; fallthrough; /* maybe userspace knows this conn_id */ case HVCALL_POST_MESSAGE: + if (unlikely(!(hv_vcpu->cpuid_cache.features_ebx & + HV_POST_MESSAGES))) { + ret = HV_STATUS_ACCESS_DENIED; + break; + } + /* don't bother userspace if it has no way to handle it */ if (unlikely(rep || !to_hv_synic(vcpu)->active)) { ret = HV_STATUS_INVALID_HYPERCALL_INPUT; -- 2.30.2