From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34955C43460 for ; Wed, 14 Apr 2021 07:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0328C61220 for ; Wed, 14 Apr 2021 07:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349090AbhDNHv5 (ORCPT ); Wed, 14 Apr 2021 03:51:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:36870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348092AbhDNHvx (ORCPT ); Wed, 14 Apr 2021 03:51:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0C7B1601FE; Wed, 14 Apr 2021 07:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618386692; bh=zojRrA+SEVZVplxBJb0vmN6/7XHw2L494AoVKdAZjdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YjXZBIfzmd7krID9ftFF5zj6n3QXwljc5UVtlmUIp1qczKposRteSwRn1SCkkSB79 xXDGH2kHe1xw88jPPcIKqX/aQL/sEOupEL0rHQV3jBcXXswbsCU+L/kGFhuHeir97M 5A5IjzfNLtrRAh6PR6VqgTW+LxljS986sk1epPKBI8cB1o9VwzIEV+Bt3Nxl0G8T+L LLvqn0bGE46cJtctKu9AZHUWOrZd/7AcXJocdzWCXBOD3EvBVCwglCq2qz9UIMuKw5 omyLVHoSitohTApoN36vTizS4duxBYm5B5NTV9plqWGVBVmzZS+s2txkDtQUxc7JKa jq5jPwKzpLyrg== Date: Wed, 14 Apr 2021 09:51:27 +0200 From: Wolfram Sang To: Qinglang Miao Cc: Michal Simek , Dong Aisheng , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Oleksij Rempel , Vignesh R , Aaro Koskinen , Tony Lindgren , Orson Zhai , Baolin Wang , Chunyan Zhang , Pierre-Yves MORDRET , Maxime Coquelin , Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] i2c: fix reference leak when pm_runtime_get_sync fails Message-ID: <20210414075127.GA2180@ninjato> References: <20201201092924.112461-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <20201201092924.112461-1-miaoqinglang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --opJtzjQTFsWo+cga Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 01, 2020 at 05:29:24PM +0800, Qinglang Miao wrote: > pm_runtime_get_sync will increment the PM reference count > even failed. Forgetting to putting operation will result > in a reference leak here.=20 >=20 > Replace it with pm_runtime_resume_and_get to keep usage > counter balanced.=20 >=20 > BTW, pm_runtime_resume_and_get is introduced in v5.10-rc5 as > dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get > to dealwith usage counter") >=20 > Qinglang Miao (8): > i2c: cadence: fix reference leak when pm_runtime_get_sync fails > i2c: img-scb: fix reference leak when pm_runtime_get_sync fails > i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails > i2c: imx: fix reference leak when pm_runtime_get_sync fails > i2c: omap: fix reference leak when pm_runtime_get_sync fails > i2c: sprd: fix reference leak when pm_runtime_get_sync fails > i2c: stm32f7: fix reference leak when pm_runtime_get_sync fails > i2c: xiic: fix reference leak when pm_runtime_get_sync fails I applied this series now to for-next, thanks! --opJtzjQTFsWo+cga Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmB2nvsACgkQFA3kzBSg KbbCtw/+NcMmI6QKvhWoRpGzsqS4JR3ve8xPWFEaYBcBABOFAJ3OtQeYoeFXyFv5 xJVaL0EqvTsppo22meJ8HGSDgp8cnGupdpwZhIWUxEAdwV2XPabWGQM0IOhq5fIo EXDs+bWvDeo0FqHi/fnc3ykUYXeEo2eh2te+rdhrQy8/l9HdzeFJhx7zOvu2bl/y F5sindz+A6+JxmDGrv5ocmCKDV0/ESIQG4QKadxtRrvNM55hkR7HLBo/XC3iwZx/ XSAJwJNwTxCLhIE2YHhSvO0vnMbXD/rcia9nJ+KcNRSDzNRu/KnECzM1r5HZ4k/8 iWKGyC5eZDfeBMDGDtBs3puS5lktt5bdeBJevXHkSch5Vjaa30fojPbAwHo7paHk v5ojLq1mXX38TkeVvofFBjF7XVyiNuiUwxcIFPHiu38AeSQdkAPRLczyRuU+1yNU uZ7fRS7UPZYy3twjnvgiAdSqiZXa3Z30pgD/bULDwZA39fsXiqg47/vh8pVUI9A6 fz/I3LOyn7qwxxGrLxvErdyAJXazGvEF+pouaAF0XKNgB7iokFV3t1YGTV7IZoWd Cg29vCPjjUsFTnaj1HNIjN0KDYD7kDjqzeYRQzzfPStheExujd2I5qtyZVhOKRal +AkE/oTuRAlxrmNH6/N3pgLdayySwS70gZ4mOGSO8bE/xV/bL+Q= =dXOi -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--