From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED05C433ED for ; Wed, 14 Apr 2021 13:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2394D611AD for ; Wed, 14 Apr 2021 13:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349067AbhDNNrT (ORCPT ); Wed, 14 Apr 2021 09:47:19 -0400 Received: from m12-13.163.com ([220.181.12.13]:60644 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345747AbhDNNrR (ORCPT ); Wed, 14 Apr 2021 09:47:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=EwR7Y maNzMnTWlCwuzu9rGM9euqfHcYpRoRM9HqWawQ=; b=NF8/QUYVtND8drmycdWI+ 92L+V65+hYED2ANRa0tmoDUnOqE5RxicVJZUX++2KVIKz/3CjnHK+U69rV/2WfvY PZFzcbbJ8FEecmcrOasPsoLW7R1mU5CGyI1nk4F6klBlMSeykGL1Ivf3Pauv3GXs CMSBRs3DMM17wLCkZfPWJw= Received: from COOL-20201210PM.ccdomain.com (unknown [218.94.48.178]) by smtp9 (Coremail) with SMTP id DcCowACHtL0+8nZgU4mXFw--.25576S2; Wed, 14 Apr 2021 21:46:42 +0800 (CST) From: zuoqilin1@163.com To: mhiramat@kernel.org Cc: linux-kernel@vger.kernel.org, zuoqilin Subject: [PATCH] tools/bootconfig: Simplify expression Date: Wed, 14 Apr 2021 21:46:47 +0800 Message-Id: <20210414134647.1870-1-zuoqilin1@163.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DcCowACHtL0+8nZgU4mXFw--.25576S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF13XF43urWxtw1kZryDGFg_yoW3Kwb_Kr 95Zr18KrWfJry8ArsrWrZ8Wr40gF98WFs7t3yIkFy3ta1UXw17J3WkCwsxXFy5Wa9rtFy3 WF4FkasFkw43ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU1zVbJUUUUU== X-Originating-IP: [218.94.48.178] X-CM-SenderInfo: 52xr1xpolqiqqrwthudrp/1tbiZQJ0iV8ZN04rRAAAsK Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zuoqilin It is not necessary to define the variable ret to receive the return value of the xbc_node_compose_key() method. Signed-off-by: zuoqilin --- tools/bootconfig/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c index 7362bef..5fb309b 100644 --- a/tools/bootconfig/main.c +++ b/tools/bootconfig/main.c @@ -84,11 +84,9 @@ static void xbc_show_list(void) char key[XBC_KEYLEN_MAX]; struct xbc_node *leaf; const char *val; - int ret = 0; xbc_for_each_key_value(leaf, val) { - ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX); - if (ret < 0) + if (xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX) < 0) break; printf("%s = ", key); if (!val || val[0] == '\0') { -- 1.9.1