From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5469C433ED for ; Wed, 14 Apr 2021 18:14:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEE606120E for ; Wed, 14 Apr 2021 18:14:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352923AbhDNSPE (ORCPT ); Wed, 14 Apr 2021 14:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352483AbhDNSMn (ORCPT ); Wed, 14 Apr 2021 14:12:43 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AE9DC06175F for ; Wed, 14 Apr 2021 11:12:20 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id e7so24778399edu.10 for ; Wed, 14 Apr 2021 11:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d9HiwiG5kORRP979bbG30Pb7khVbAENnO6ggL6MZz60=; b=QrOt/uHCJ3e6Qz3w0WSXTt33lNtjA8DWeeV5itxerWAK3oJxl9hJnUILW+FfGuqMJI 1UcS1TjKe0RXBImdPqU/8Y6cQhH0YF75ax1doFRFO7BNP+h7KZOIfMNA2guLtMJTk8MK m1T/Hwhb/kyiQRb7G9CR7jBTLItIQdh/oKcwK4vQQ10ov9xKArJURiDa0CQ05kY03Ac1 byj19KPeRvSkAvHxOjJg7O65sRlj/NuARm1le2IFwguNgE06ETGhML6rVy1ez9CIprzk KONKLxhyy0wr7fpG5ADB0auUJZbqC7Q1PPXy7L6GtpQpS5IB2TsN6Pj/I7yNEgArbu78 NAhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d9HiwiG5kORRP979bbG30Pb7khVbAENnO6ggL6MZz60=; b=neL2Fv9ehwn7eXN52L/rSA9CFt2UkhWFFMHJ9LT7a+Y69sZDMUs34a/xvVAECzjpV3 mTVDQqgHobmYn7qATXSc+wwFPvVcOLuPEL7PGC9RQQFRgU21nyN0vviRvf6OiHpHDUK5 eDr/DxY7L7vXOofAEqzuOFx5X5NnJGM+t4JxhCOcRUnJeUE9uxQAyUGL+Kt6ItnDvZZg 1mXZFbo+yafK67bO5H4KDAVySLQBVZnM+Gtso23Y4na0ksNCPq7bmVSELEXFIFVUPNpi z0UK3OOObksG+VKQIl734PQRM5uVdShnAQDpeNHCfRm4cpg4SfBR5ASWr3PpICdQfZc2 /DQA== X-Gm-Message-State: AOAM532tQkWGgbIgvAy6WT0hTRqQFfhI1qC+A76d0pmF7pZl+RqA/Wku K40HObASUzHuSA4FkxOU+dCJtBKHEGb2yQ== X-Google-Smtp-Source: ABdhPJxsWN+SnAz2cYauW5tYfq2NgNpb6CwNSOshksFaL7jjG8cCmFimJJIrsxOS+FHy4hfPGClHuQ== X-Received: by 2002:a05:6402:b07:: with SMTP id bm7mr209420edb.82.1618423939188; Wed, 14 Apr 2021 11:12:19 -0700 (PDT) Received: from dell.default ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id v1sm279493eds.17.2021.04.14.11.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 11:12:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Marco Cesati , Fabio Aiuto , Stanley@BB.SD3, linux-staging@lists.linux.dev Subject: [PATCH 43/57] staging: rtl8723bs: hal: rtl8723b_hal_init: Remove unused variable and dead code Date: Wed, 14 Apr 2021 19:11:15 +0100 Message-Id: <20210414181129.1628598-44-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210414181129.1628598-1-lee.jones@linaro.org> References: <20210414181129.1628598-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c: In function ‘CCX_FwC2HTxRpt_8723b’: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3355:5: warning: variable ‘seq_no’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Marco Cesati Cc: Fabio Aiuto Cc: Stanley@BB.SD3 Cc: linux-staging@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 8d6ea8850556f..4773f0dcd9819 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -3199,23 +3199,14 @@ static void hw_var_set_mlme_join(struct adapter *padapter, u8 variable, u8 *val) void CCX_FwC2HTxRpt_8723b(struct adapter *padapter, u8 *pdata, u8 len) { - u8 seq_no; - #define GET_8723B_C2H_TX_RPT_LIFE_TIME_OVER(_Header) LE_BITS_TO_1BYTE((_Header + 0), 6, 1) #define GET_8723B_C2H_TX_RPT_RETRY_OVER(_Header) LE_BITS_TO_1BYTE((_Header + 0), 7, 1) - seq_no = *(pdata+6); - if (GET_8723B_C2H_TX_RPT_RETRY_OVER(pdata) | GET_8723B_C2H_TX_RPT_LIFE_TIME_OVER(pdata)) { rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_CCX_PKT_FAIL); - } -/* - else if (seq_no != padapter->xmitpriv.seq_no) { - rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_CCX_PKT_FAIL); - } -*/ - else + } else { rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_SUCCESS); + } } s32 c2h_id_filter_ccx_8723b(u8 *buf) -- 2.27.0