From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39EA4C433B4 for ; Wed, 14 Apr 2021 18:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 189166121E for ; Wed, 14 Apr 2021 18:15:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233908AbhDNSQD (ORCPT ); Wed, 14 Apr 2021 14:16:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352522AbhDNSMy (ORCPT ); Wed, 14 Apr 2021 14:12:54 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7D1AC061756 for ; Wed, 14 Apr 2021 11:12:31 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 18so24856166edx.3 for ; Wed, 14 Apr 2021 11:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O1aFTwFa3e7XfhNdQLIqRt53XzZNGqwukxfvFSfxhVw=; b=s1vgJHd0xERyv+jYDm/Ug7hVQ+VjvmU0pKdnS8SJCPO0RjDfhe8vn9sw5wirMQ7DqU uuU4+nf9mSXn2LMcTVUi9w+5z6oiJSkhRzsztCxFDXmjazhM6sx52zqXOiZaDWtzT8S9 Gk/rHS5sgGljaEWw2h++O165TJIR+aAPpVj29oLeILqbN/F+hWkWyw8LTb4E/P/I5Ycv e2kNpJ5F8FDMkXspeIuqld1m/K7c/7NTvHnoFtacZb3ylfklZpIDfmQQxwqy8sNVdsp1 vclhfB1a0yuFoOnyj9zq+jIMvNJk9UZUqnWyLT+wcRXGgBaWZ8dzxfN2ORpcW3Zku6ut BtQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O1aFTwFa3e7XfhNdQLIqRt53XzZNGqwukxfvFSfxhVw=; b=PBiv9dONT8D56YU20xR5FsJlNQJ4fwy9UNFkjz2NqKof8h/KZVM4cj0Sa5ZlEs/J8p W4LvtMU7xGHBcqomn41eBWyI01kzCCHCPbnYoBuH8SpO5LeJmshWVSAu7H4gKCohTL9T Vo0qa3Fdq9JvVRWqeFf9xy5FCkcrqroH5vSwmj+AhyQ0JOoJriM9x//dI6OLTeHa7pYU oPaM0a1/Umly/7iBbwxQnxWYQEdsczpPi3bMHQbZeQrQLtf0yqejlUuDbGkijhF+MTq4 FIjhU7nDCJbEdH9+zzH4AoebB/dgL0uMpwNtQyzh06KXTp1BopvGoLLOFQKfMZbFq98H CK9g== X-Gm-Message-State: AOAM5313gxiKu/wheNwKOF8HlxpfljEGEf4hs7SLe7EtX9QAVTOvCawL 0hHxFdrhoAout4hr+Sf+NtEc5w== X-Google-Smtp-Source: ABdhPJwfsQYUqv4wT3YXO5qYgt7SaeynRLeosZJw6WqDJRIvdoW8NTosiObVvnIPhbUMDVJdV2Cz8w== X-Received: by 2002:a05:6402:1685:: with SMTP id a5mr163642edv.185.1618423950410; Wed, 14 Apr 2021 11:12:30 -0700 (PDT) Received: from dell.default ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id v1sm279493eds.17.2021.04.14.11.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 11:12:30 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-staging@lists.linux.dev Subject: [PATCH 53/57] staging: rtl8723bs: core: rtw_mlme_ext: Move very large data buffer onto the heap Date: Wed, 14 Apr 2021 19:11:25 +0100 Message-Id: <20210414181129.1628598-54-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210414181129.1628598-1-lee.jones@linaro.org> References: <20210414181129.1628598-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/staging/rtl8723bs/core/rtw_mlme_ext.c: In function ‘issue_probersp’: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:2543:1: warning: the frame size of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index f708e7b9f8fc8..78ca8fbaab8da 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -2450,9 +2450,13 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p u8 *ssid_ie; signed int ssid_ielen; signed int ssid_ielen_diff; - u8 buf[MAX_IE_SZ]; + u8 *buf; u8 *ies = pmgntframe->buf_addr+TXDESC_OFFSET+sizeof(struct ieee80211_hdr_3addr); + buf = rtw_zmalloc(MAX_IE_SZ); + if (!buf) + return; + ssid_ie = rtw_get_ie(ies+_FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_ielen, (pframe-ies)-_FIXED_IE_LENGTH_); @@ -2478,6 +2482,7 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p pframe += ssid_ielen_diff; pattrib->pktlen += ssid_ielen_diff; } + kfree (buf); } } else { /* timestamp will be inserted by hardware */ -- 2.27.0