From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6E4C433B4 for ; Wed, 14 Apr 2021 20:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE04D61042 for ; Wed, 14 Apr 2021 20:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349971AbhDNU1T (ORCPT ); Wed, 14 Apr 2021 16:27:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:50124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232940AbhDNU1O (ORCPT ); Wed, 14 Apr 2021 16:27:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 332FA61090; Wed, 14 Apr 2021 20:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618432012; bh=+tL5RoPUY0L+AS8fwgMWwYIbyeP9WumdPTZtx6+OaVs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=rjtCFBiQsFK8cHVxOA+QVwj1EgsfDzZ7acAImmZ+sGbRsSc88oAGYdb/lwRWtclJZ ez4qZbimFgknQsiGSFtPYZ7QhXpCqwL6DjHlFjT9Oca1blAW71NitTL6wl+ewOdtr4 ZEoqgXxqUpBFnOyOXw1t63J+NVCWGFQo97alxMqhupVSe3AFDXkk8Dn3fTuDukRIy2 eTeBtVk+XBOKrL6zJJhNTrsf9Q2lWG0+3uiqPPBtyKA2SYv8uFReX8pI03Tw4Jqckm 9uitz38zFCR5SCMziDPpyVfjT0H5oGIVdR/wWVkjRuh9mb9l4Kd2ldpKZS0HbLcAv1 Z1XNfwWHNIv5A== Date: Wed, 14 Apr 2021 15:26:50 -0500 From: Bjorn Helgaas To: Huang Guobin Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] PCI: Use DEFINE_SPINLOCK() for spinlock Message-ID: <20210414202650.GA2534339@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617710797-48903-1-git-send-email-huangguobin4@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 08:06:37PM +0800, Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang Applied to pci/hotplug for v5.13, thanks! > --- > drivers/pci/hotplug/cpqphp_nvram.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/pci/hotplug/cpqphp_nvram.c b/drivers/pci/hotplug/cpqphp_nvram.c > index 00cd2b43364f..7a65d427ac11 100644 > --- a/drivers/pci/hotplug/cpqphp_nvram.c > +++ b/drivers/pci/hotplug/cpqphp_nvram.c > @@ -80,7 +80,7 @@ static u8 evbuffer[1024]; > static void __iomem *compaq_int15_entry_point; > > /* lock for ordering int15_bios_call() */ > -static spinlock_t int15_lock; > +static DEFINE_SPINLOCK(int15_lock); > > > /* This is a series of function that deals with > @@ -415,9 +415,6 @@ void compaq_nvram_init(void __iomem *rom_start) > compaq_int15_entry_point = (rom_start + ROM_INT15_PHY_ADDR - ROM_PHY_ADDR); > > dbg("int15 entry = %p\n", compaq_int15_entry_point); > - > - /* initialize our int15 lock */ > - spin_lock_init(&int15_lock); > } > > >