From: Bean Huo <huobean@gmail.com>
To: ulf.hansson@linaro.org, wsa+renesas@sang-engineering.com,
adrian.hunter@intel.com, yoshihiro.shimoda.uh@renesas.com
Cc: beanhuo@micron.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 2/2] mmc: core: Let sanitize not retry in case of timeout/failure
Date: Wed, 14 Apr 2021 23:22:36 +0200 [thread overview]
Message-ID: <20210414212236.346813-3-huobean@gmail.com> (raw)
In-Reply-To: <20210414212236.346813-1-huobean@gmail.com>
From: Bean Huo <beanhuo@micron.com>
Not any commands need to retry in case of timeout/failure.
Currently, the sanitize command is issued by the IOCTL interface,
and once its timeouts, the user normally decides to retry or not .
Just blindly retry three times sanitize in the driver, it doesn't
help sanitize retry succeed in the end, on the contrary, it only
makes the user feel sanitize timeouts after 12 minutes.
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
drivers/mmc/core/mmc_ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index 1ca0c89081be..cdf02d88fe92 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -1028,8 +1028,8 @@ int mmc_sanitize(struct mmc_card *card, unsigned int timeout_ms)
mmc_retune_hold(host);
- err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_SANITIZE_START,
- 1, timeout_ms);
+ err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_SANITIZE_START,
+ 1, timeout_ms, 0, true, false, 0);
if (err)
pr_err("%s: Sanitize failed err=%d\n", mmc_hostname(host), err);
--
2.25.1
next prev parent reply other threads:[~2021-04-14 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 21:22 [PATCH v1 0/2] Let sanitize not retry in case of timeout/failure Bean Huo
2021-04-14 21:22 ` [PATCH v1 1/2] mmc: core: Add a retries parameter to __mmc_switch function Bean Huo
2021-04-14 21:22 ` Bean Huo [this message]
2021-04-15 12:02 ` [PATCH v1 0/2] Let sanitize not retry in case of timeout/failure Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2021-04-01 12:43 [PATCH v1 0/2] Tow minor changes of eMMC sanitize Bean Huo
2021-04-01 12:43 ` [PATCH v1 2/2] mmc: core: Let sanitize not retry in case of timeout/failure Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414212236.346813-3-huobean@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=beanhuo@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).