linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting
@ 2021-04-15 13:45 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-04-15 13:45 UTC (permalink / raw)
  To: Anna Schumaker; +Cc: kbuild-all, linux-kernel, J. Bruce Fields

[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7f75285ca572eaabc028cf78c6ab5473d0d160be
commit: 2db27992dd565bf400658edc18f67aed0b6bc6cb NFSD: Add READ_PLUS hole segment encoding
date:   6 months ago
config: x86_64-randconfig-m031-20210415 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting

Old smatch warnings:
fs/nfsd/nfs4xdr.c:679 nfsd4_decode_close() warn: ignoring unreachable code.

vim +4657 fs/nfsd/nfs4xdr.c

  4642	
  4643	static __be32
  4644	nfsd4_encode_read_plus_hole(struct nfsd4_compoundres *resp,
  4645				    struct nfsd4_read *read,
  4646				    unsigned long maxcount, u32 *eof)
  4647	{
  4648		struct file *file = read->rd_nf->nf_file;
  4649		__be32 *p;
  4650	
  4651		/* Content type, offset, byte count */
  4652		p = xdr_reserve_space(&resp->xdr, 4 + 8 + 8);
  4653		if (!p)
  4654			return nfserr_resource;
  4655	
  4656		*p++ = htonl(NFS4_CONTENT_HOLE);
> 4657		 p   = xdr_encode_hyper(p, read->rd_offset);
  4658		 p   = xdr_encode_hyper(p, maxcount);
  4659	
  4660		*eof = (read->rd_offset + maxcount) >= i_size_read(file_inode(file));
  4661		return nfs_ok;
  4662	}
  4663	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35919 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting
@ 2021-06-09 21:03 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-06-09 21:03 UTC (permalink / raw)
  To: Anna Schumaker; +Cc: kbuild-all, linux-kernel, J. Bruce Fields

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   368094df48e680fa51cedb68537408cfa64b788e
commit: 2db27992dd565bf400658edc18f67aed0b6bc6cb NFSD: Add READ_PLUS hole segment encoding
date:   8 months ago
config: h8300-randconfig-m031-20210609 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting

Old smatch warnings:
fs/nfsd/nfs4xdr.c:679 nfsd4_decode_close() warn: ignoring unreachable code.

vim +4657 fs/nfsd/nfs4xdr.c

  4642	
  4643	static __be32
  4644	nfsd4_encode_read_plus_hole(struct nfsd4_compoundres *resp,
  4645				    struct nfsd4_read *read,
  4646				    unsigned long maxcount, u32 *eof)
  4647	{
  4648		struct file *file = read->rd_nf->nf_file;
  4649		__be32 *p;
  4650	
  4651		/* Content type, offset, byte count */
  4652		p = xdr_reserve_space(&resp->xdr, 4 + 8 + 8);
  4653		if (!p)
  4654			return nfserr_resource;
  4655	
  4656		*p++ = htonl(NFS4_CONTENT_HOLE);
> 4657		 p   = xdr_encode_hyper(p, read->rd_offset);
  4658		 p   = xdr_encode_hyper(p, maxcount);
  4659	
  4660		*eof = (read->rd_offset + maxcount) >= i_size_read(file_inode(file));
  4661		return nfs_ok;
  4662	}
  4663	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28037 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting
@ 2020-10-28 23:24 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-10-28 23:24 UTC (permalink / raw)
  To: Anna Schumaker; +Cc: kbuild-all, linux-kernel, J. Bruce Fields

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   23859ae44402f4d935b9ee548135dd1e65e2cbf4
commit: 2db27992dd565bf400658edc18f67aed0b6bc6cb NFSD: Add READ_PLUS hole segment encoding
date:   2 weeks ago
config: parisc-randconfig-m031-20201028 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting

Old smatch warnings:
fs/nfsd/nfs4xdr.c:679 nfsd4_decode_close() warn: ignoring unreachable code.

vim +4657 fs/nfsd/nfs4xdr.c

  4642	
  4643	static __be32
  4644	nfsd4_encode_read_plus_hole(struct nfsd4_compoundres *resp,
  4645				    struct nfsd4_read *read,
  4646				    unsigned long maxcount, u32 *eof)
  4647	{
  4648		struct file *file = read->rd_nf->nf_file;
  4649		__be32 *p;
  4650	
  4651		/* Content type, offset, byte count */
  4652		p = xdr_reserve_space(&resp->xdr, 4 + 8 + 8);
  4653		if (!p)
  4654			return nfserr_resource;
  4655	
  4656		*p++ = htonl(NFS4_CONTENT_HOLE);
> 4657		 p   = xdr_encode_hyper(p, read->rd_offset);
  4658		 p   = xdr_encode_hyper(p, maxcount);
  4659	
  4660		*eof = (read->rd_offset + maxcount) >= i_size_read(file_inode(file));
  4661		return nfs_ok;
  4662	}
  4663	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36051 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-09 21:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 13:45 fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-06-09 21:03 kernel test robot
2020-10-28 23:24 kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).