From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8180FC433ED for ; Fri, 16 Apr 2021 06:58:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EC6761166 for ; Fri, 16 Apr 2021 06:58:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239184AbhDPG6X (ORCPT ); Fri, 16 Apr 2021 02:58:23 -0400 Received: from elvis.franken.de ([193.175.24.41]:53206 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234691AbhDPG6W (ORCPT ); Fri, 16 Apr 2021 02:58:22 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lXIQM-0007bP-00; Fri, 16 Apr 2021 08:57:54 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 36909C0489; Fri, 16 Apr 2021 08:54:42 +0200 (CEST) Date: Fri, 16 Apr 2021 08:54:42 +0200 From: Thomas Bogendoerfer To: Andrew Lunn Cc: "David S. Miller" , Jakub Kicinski , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next 06/10] net: korina: Only pass mac address via platform data Message-ID: <20210416065442.GA5082@alpha.franken.de> References: <20210414230648.76129-1-tsbogend@alpha.franken.de> <20210414230648.76129-7-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 01:30:04AM +0200, Andrew Lunn wrote: > On Thu, Apr 15, 2021 at 01:06:43AM +0200, Thomas Bogendoerfer wrote: > > Get rid of access to struct korina_device by just passing the mac > > address via platform data and use drvdata for passing netdev to remove > > function. > > > > Signed-off-by: Thomas Bogendoerfer > > --- > > arch/mips/rb532/devices.c | 5 +++-- > > drivers/net/ethernet/korina.c | 11 ++++++----- > > 2 files changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c > > index dd34f1b32b79..5fc3c8ee4f31 100644 > > --- a/arch/mips/rb532/devices.c > > +++ b/arch/mips/rb532/devices.c > > @@ -105,6 +105,9 @@ static struct platform_device korina_dev0 = { > > .name = "korina", > > .resource = korina_dev0_res, > > .num_resources = ARRAY_SIZE(korina_dev0_res), > > + .dev = { > > + .platform_data = &korina_dev0_data.mac, > > + } > > This is a bit unusual. Normally you define a structure in > include/linux/platform/data/koriana.h, and use that. > > What about the name? "korina0" How is that passed? this is just for transition purpose. My DT patches remove this struct completly. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]