From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: zhaoxiao <zhaoxiao@uniontech.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, hpa@zytor.com, nivedita@alum.mit.edu,
clin@suse.com, andriy.shevchenko@linux.intel.com,
ndesaulniers@google.com, dan.j.williams@intel.com,
masahiroy@kernel.org, linux-kernel@vger.kernel.org,
jroedel@suse.de, peterz@infradead.org
Subject: Re: [PATCH v2] X86: Makefile: Replace -pg with CC_FLAGS_FTRACE
Date: Fri, 16 Apr 2021 12:49:55 -0400 [thread overview]
Message-ID: <20210416124955.64e824e3@gandalf.local.home> (raw)
In-Reply-To: <20210416151258.gjchvi7c5uneiy63@treble>
On Fri, 16 Apr 2021 10:12:58 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> Adding Steven Rostedt (ftrace maintainer).
Thanks.
>
> On Fri, Apr 16, 2021 at 01:39:28PM +0800, zhaoxiao wrote:
> > In preparation for x86 supporting ftrace built on other compiler
> > options, let's have the x86 Makefiles remove the $(CC_FLAGS_FTRACE)
> > flags, whatever these may be, rather than assuming '-pg'.
> >
> > There should be no functional change as a result of this patch.
> >
> > Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> > ---
> > v2: add the same change for the other Makefile in arch/x86 directory.
> > arch/x86/entry/vdso/Makefile | 8 ++++----
> > arch/x86/kernel/Makefile | 16 ++++++++--------
> > arch/x86/kernel/cpu/Makefile | 4 ++--
> > arch/x86/lib/Makefile | 2 +-
> > arch/x86/mm/Makefile | 4 ++--
> > arch/x86/xen/Makefile | 6 +++---
> > 6 files changed, 20 insertions(+), 20 deletions(-)
> >
I'm good with switching "-pg" over to "$(CC_FLAGS_FTRACE)" globally.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2021-04-16 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 5:39 [PATCH v2] X86: Makefile: Replace -pg with CC_FLAGS_FTRACE zhaoxiao
2021-04-16 15:12 ` Josh Poimboeuf
2021-04-16 16:49 ` Steven Rostedt [this message]
2021-04-16 21:56 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416124955.64e824e3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=clin@suse.com \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhaoxiao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).