From: Alan Stern <stern@rowland.harvard.edu>
To: Anirudh Rayabharam <mail@anirudhrb.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+eb4674092e6cc8d9e0bd@syzkaller.appspotmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [syzbot] general protection fault in gadget_setup
Date: Fri, 16 Apr 2021 13:46:04 -0400 [thread overview]
Message-ID: <20210416174604.GA47856@rowland.harvard.edu> (raw)
In-Reply-To: <YHnD0AVXiwdsw46L@anirudhrb.com>
On Fri, Apr 16, 2021 at 10:35:20PM +0530, Anirudh Rayabharam wrote:
> On Fri, Apr 16, 2021 at 11:27:34AM -0400, Alan Stern wrote:
> > Actually, I wanted to move this emulation code into a new subroutine and
> > then call that subroutine from _both_ places. Would you like to write
>
> Does it really need to be called from both places?
You know, I was going to say Yes, but now I think you're right; it's not
needed in dummy_udc_stop. This is because core.c always calls
usb_gadget_disconnect before usb_gadget_udc_stop. And we can rely on
this behavior; it's obviously necessary to disconnect from the host
before stopping the UDC driver.
On the other hand, while checking that fact I noticed that
soft_connect_store in core.c doesn't call synchronize_irq in between the
other two, the way usb_gadget_remove_driver does. That seems like a bug
-- if it's necessary to synchronize with the IRQ handler on one path, it
should be necessary on the other path as well. But that's a matter for
a separate patch.
Alan Stern
> > and submit a patch that does this?
>
> Sure! I will do that.
>
> Thanks!
>
> - Anirudh.
prev parent reply other threads:[~2021-04-16 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 8:08 [syzbot] general protection fault in gadget_setup syzbot
2021-04-13 8:12 ` Dmitry Vyukov
2021-04-13 16:13 ` Alan Stern
2021-04-13 16:47 ` Dmitry Vyukov
2021-04-13 16:57 ` Alan Stern
2021-04-13 17:11 ` Dmitry Vyukov
2021-04-15 20:59 ` Alan Stern
2021-04-16 7:21 ` Dmitry Vyukov
2021-04-16 15:29 ` Alan Stern
2021-04-16 5:40 ` Anirudh Rayabharam
2021-04-16 15:27 ` Alan Stern
2021-04-16 17:05 ` Anirudh Rayabharam
2021-04-16 17:46 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416174604.GA47856@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=andreyknvl@gmail.com \
--cc=balbi@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@anirudhrb.com \
--cc=syzbot+eb4674092e6cc8d9e0bd@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).