From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A724C43461 for ; Sat, 17 Apr 2021 15:44:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5966D6102A for ; Sat, 17 Apr 2021 15:44:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236642AbhDQPor (ORCPT ); Sat, 17 Apr 2021 11:44:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236481AbhDQPor (ORCPT ); Sat, 17 Apr 2021 11:44:47 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A566BC061574 for ; Sat, 17 Apr 2021 08:44:20 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXn7F-0002qG-SU; Sat, 17 Apr 2021 17:44:13 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lXn7F-0006BO-FJ; Sat, 17 Apr 2021 17:44:13 +0200 Date: Sat, 17 Apr 2021 17:44:13 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Clemens Gruber Cc: Thierry Reding , Rob Herring , linux-pwm@vger.kernel.org, Sven Van Asbroeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag Message-ID: <20210417154413.dk2ayjx4y3vo7mnd@pengutronix.de> References: <20210412132745.76609-1-clemens.gruber@pqgruber.com> <20210412132745.76609-4-clemens.gruber@pqgruber.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pnu6i5tqpbwo77xn" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pnu6i5tqpbwo77xn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 16, 2021 at 05:54:29PM +0200, Clemens Gruber wrote: > On Fri, Apr 16, 2021 at 03:55:11PM +0200, Thierry Reding wrote: > > On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote: > > > Add the flag and corresponding documentation for PWM_USAGE_POWER. > > >=20 > > > Cc: Rob Herring > > > Signed-off-by: Clemens Gruber > > > --- > > > Documentation/devicetree/bindings/pwm/pwm.txt | 3 +++ > > > include/dt-bindings/pwm/pwm.h | 1 + > > > 2 files changed, 4 insertions(+) > >=20 > > Rob, what are your thoughts on this? I've been thinking about this some > > more and I'm having second thoughts about putting this into device tree > > because it doesn't actually describe a property of the PWM hardware but > > rather a use-case specific hint. It's a bit of a gray area because this > > is just part of the PWM specifier which already has use-case specific > > "configuration", such as the period and the polarity. This is something I'd prefer over making it part of the device tree API. I still don't think it's a good idea but when we keep it in-kernel we can at least easier modify it in the future. > > Perhaps a better place for this is within the PWM API? We could add the > > same information into struct pwm_state and then consumers that don't > > care about specifics of the signal (such as pwm-backlight) can set that > > flag when they request a state to be applied. >=20 > I just want to note that in my opinion, this is not a flag that is > changed often, so is it really a good idea to require setting this > wherever PWM state is applied? Also, this can't be read-out in > .get_state. Not being able to read it out isn't a problem in my eyes. > Thierry: If this discussion carries on and a v10 is required: Could you > maybe merge the uncontroversial patches 1 to 3 of v9 separately and > maybe get those in 5.12 ? Patches 4 to 8 can probably wait for 5.13 and > have some time in linux-next. I'm ok in getting those into next now and than into the upcoming merge window. That won't make them part of 5.12 however, but 5.13-rc1. IMHO patches 7 and 8 can go in, too. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --pnu6i5tqpbwo77xn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmB7AkoACgkQwfwUeK3K 7AlHjwgAkM6agKrKkVI46Cb6cL1zJJ/NmFQvWDmwGF0c2zE7ODULf+RXWBWsbG6v cd7mYxS1yikwcyemX2OgLp4y7NHM6PWfgrJkIAn8BeH3BSDP5S70KYKscVyLenfr +pZvuYKDYD0hsrD2QcL60uhQwbL5B3cHxFtzFT3mNhEpw0u1hbvFp9rQAwQSiro6 MBMy7CMmieTA0r83drbHhXwBNVD4pLj1Glq8FUdyy2GIjVkY3O2qDlUI8L5eNn6u 2JMvDzuLIZ5xZ3tloA3tynWQge98u9yWF0x4s5+997IrR4+NSZ8INpuas+R0LaXl 0PNu0UD9AJIw6dkZyYalGKSLqgAJSw== =rkie -----END PGP SIGNATURE----- --pnu6i5tqpbwo77xn--