From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 468D8C433ED for ; Mon, 19 Apr 2021 06:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A13061165 for ; Mon, 19 Apr 2021 06:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232942AbhDSGvC (ORCPT ); Mon, 19 Apr 2021 02:51:02 -0400 Received: from verein.lst.de ([213.95.11.211]:45334 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbhDSGvB (ORCPT ); Mon, 19 Apr 2021 02:51:01 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4B68D68B05; Mon, 19 Apr 2021 08:50:28 +0200 (CEST) Date: Mon, 19 Apr 2021 08:50:27 +0200 From: Christoph Hellwig To: Kai-Heng Feng Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, Alex Deucher , Prike Liang , Shyam Sundar S K , "open list:NVM EXPRESS DRIVER" , open list Subject: Re: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device supports it Message-ID: <20210419065027.GA19201@lst.de> References: <20210416091344.1210803-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416091344.1210803-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 05:13:44PM +0800, Kai-Heng Feng wrote: > On AMD platforms that use s2idle, NVMe timeouts on s2idle resume, > because their SMU FW may cut off NVMe power during sleep. We're already have a discussion on a proper quirk for thse broken platforms on the linux-nvme list, please take part in that discussion.