From: Nishanth Menon <nm@ti.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tero Kristo <kristo@kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] dt-bindings: clock: Convert ti,sci-clk to json schema
Date: Mon, 19 Apr 2021 08:35:42 -0500 [thread overview]
Message-ID: <20210419133542.ndgkmf7eq4oqse34@ladies> (raw)
In-Reply-To: <20210417125127.vigq23mdoodje6b5@velcro>
Stephen,
On 07:51-20210417, Nishanth Menon wrote:
> On 16:55-20210416, Stephen Boyd wrote:
> > Quoting Nishanth Menon (2021-04-15 23:37:19)
> > > diff --git a/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml b/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml
> > > new file mode 100644
> > > index 000000000000..72633651f0c7
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml
> > > @@ -0,0 +1,52 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/clock/ti,sci-clk.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: TI-SCI clock controller node bindings
> > > +
> > > +maintainers:
> > > + - Nishanth Menon <nm@ti.com>
> > > +
> > > +allOf:
> > > + - $ref: /schemas/clock/clock.yaml#
> >
> > Is this needed?
>
> https://github.com/devicetree-org/dt-schema/blob/master/schemas/clock/clock.yaml
> This standardizes provider properties like '#clock-cells' etc, allowing
> you to add more stricter checks or controls in the future if necessary.
>
> while:
>
> https://github.com/devicetree-org/dt-schema/blob/master/meta-schemas/clocks.yaml
> is more a consumer node description.
>
> Should I have picked a different yaml as base for a standard clock-controller
> base?
>
Thinking again, I think your comment was to drop the clock.yaml
inclusion, and, as a result this schema can become more stringent..
Could you clarify?
> >
> > > +
> > > +description: |
> > > + Some TI SoCs contain a system controller (like the Power Management Micro
> > > + Controller (PMMC) on Keystone 66AK2G SoC) that are responsible for controlling
> > > + the state of the various hardware modules present on the SoC. Communication
> > > + between the host processor running an OS and the system controller happens
> > > + through a protocol called TI System Control Interface (TI-SCI protocol).
> > > +
> > > + This clock controller node uses the TI SCI protocol to perform various clock
> > > + management of various hardware modules (devices) present on the SoC. This
> > > + node must be a child node of the associated TI-SCI system controller node.
> > > +
> > > +properties:
> > > + $nodename:
> > > + pattern: "^clock-controller$"
> >
> > Is this nodename pattern check required?
>
> I'd like the definition on rails and not subject to interpretation, and
> restrict the kind of subnodes under TISCI controller node.
>
> >
> > > +
> > > + compatible:
> > > + const: ti,k2g-sci-clk
> >
> > I thought most things keyed off the compatible string.
>
> Yes, they are. I am not sure I understand your question here. Did you
> mean to indicate that having $nodename and compatible both are
> redundant?
>
> Redundancy was'nt the intent of this schema definition, rather, I'd like
> to make sure that it is not upto interpretation or debate as to what the
> node name should be: I believe clock-controller is the correct nodename
> (without @0x... since this does'nt use reg property) instead of using
> clocks, tisci-clock as the node names.
>
>
> Do you suggest something different?
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-04-19 13:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 6:37 [PATCH 0/4] dt-bindings: soc/arm: Convert pending ti,sci* bindings to json format Nishanth Menon
2021-04-16 6:37 ` [PATCH 1/4] dt-bindings: reset: Convert ti,sci-reset to json schema Nishanth Menon
2021-04-21 22:32 ` Rob Herring
2021-04-16 6:37 ` [PATCH 2/4] dt-bindings: clock: Convert ti,sci-clk " Nishanth Menon
2021-04-16 23:55 ` Stephen Boyd
2021-04-17 12:51 ` Nishanth Menon
2021-04-19 13:35 ` Nishanth Menon [this message]
2021-04-21 22:31 ` Rob Herring
2021-04-22 14:09 ` Nishanth Menon
2021-04-16 6:37 ` [PATCH 3/4] dt-bindings: soc: ti: Convert ti,sci-pm-domain " Nishanth Menon
2021-04-21 22:36 ` [PATCH 3/4] dt-bindings: soc: ti: Convert ti, sci-pm-domain " Rob Herring
2021-04-16 6:37 ` [PATCH 4/4] dt-bindings: arm: keystone: Convert ti,sci " Nishanth Menon
2021-04-21 22:40 ` Rob Herring
2021-04-22 14:17 ` Nishanth Menon
2021-04-22 16:12 ` Rob Herring
2021-04-16 10:37 ` [PATCH 0/4] dt-bindings: soc/arm: Convert pending ti,sci* bindings to json format Tero Kristo
2021-04-21 22:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419133542.ndgkmf7eq4oqse34@ladies \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).