From: Alan Stern <stern@rowland.harvard.edu>
To: Chris Chiu <chris.chiu@canonical.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
m.v.b@runbox.com, hadess@hadess.net, linux-usb@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub
Date: Mon, 19 Apr 2021 10:19:21 -0400 [thread overview]
Message-ID: <20210419141921.GA133494@rowland.harvard.edu> (raw)
In-Reply-To: <CABTNMG25qPvVu7+EsvEgaUsU_v6jKkSKCaU5VR8CiX3oLQ4VFg@mail.gmail.com>
On Mon, Apr 19, 2021 at 01:11:38AM -0400, Chris Chiu wrote:
> Sorry that I didn't make myself clear. I found that if I applied RESET_RESUME
> quirk on the problematic hub, the Set-Port-Feature(suspend) timeout error
> disappeared. SInce the timeout is not happening for each suspend by default,
> I suspect maybe reset-resume take everything back to clean state for the hub
> and the Set-Port-Feature(suspend) can be taken care of w/o problems.
Okay, that's a good solution for system suspend.
> I didn't like RESET_RESUME because runtime PM would not work on the quirked
> device.
A more interesting question is whether it will work for devices plugged
into the hub. Even though the hub won't be runtime suspended, the
things attached to it might be.
> But if the Set-Port-Feature(suspend) can't be handled and
> skipped, I can't
> expect the runtime PM to work for all devices connected to the hub either.
> Is that right? If what I proposed in the patch can not get better
> result than existing
> quirk, I think using the RESET_RESUME would be a better option. Any suggestions?
Try the RESET_RESUME quirk and see how well it works with runtime
suspend.
Alan Stern
next prev parent reply other threads:[~2021-04-19 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 11:48 [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub chris.chiu
2021-04-15 12:31 ` Greg KH
2021-04-15 16:13 ` Chris Chiu
2021-04-15 18:46 ` Alan Stern
2021-04-16 1:24 ` Chris Chiu
2021-04-16 15:39 ` Alan Stern
2021-04-19 5:11 ` Chris Chiu
2021-04-19 14:19 ` Alan Stern [this message]
2021-04-20 7:14 ` Chris Chiu
2021-04-20 15:28 ` Alan Stern
2021-04-20 16:54 ` Chris Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419141921.GA133494@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.v.b@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).