From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6000C43460 for ; Mon, 19 Apr 2021 19:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82E0D61363 for ; Mon, 19 Apr 2021 19:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241486AbhDSTSZ (ORCPT ); Mon, 19 Apr 2021 15:18:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237147AbhDSTSX (ORCPT ); Mon, 19 Apr 2021 15:18:23 -0400 Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B86F7C06174A for ; Mon, 19 Apr 2021 12:17:51 -0700 (PDT) Received: by mail-oo1-xc2a.google.com with SMTP id i9-20020a4ad0890000b02901efee2118aaso418218oor.7 for ; Mon, 19 Apr 2021 12:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m5D38FPKaVXPaWXHSFPjwGl10L5uuS1G4hWLi/5rSB0=; b=x8en4fC2bgy4uHZ0IMu38lYJhWK5Bbb2VGbO9ieiCefUCXHF0m5MJB8BPR9MhYsyUO Ndz0vzM3qHHnJRY661VVZtSmYlc4bONSPXqw5mR38ppyo0T8hc4a23GmfxEyJdevtK6Y vpEa1PQ4T4YY6Cj5Sizpn7Tyv+tRiAUYP4BDr4bIUYRQdzpBDToOwhazC05QXkroWJoU uGQGKfDDBeA45vDC+TEoHTtUbKv6RlH7riNFKvPJcozKHR9BUZ5lX7Kk2ZpNYL70e6kp y84l4RRhcdfeNAt/L1ywRpTqTx6TrKVMRpbNkJJp5Yu8y3K5ui0Fz43nxNZMT30hRUi1 vBKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m5D38FPKaVXPaWXHSFPjwGl10L5uuS1G4hWLi/5rSB0=; b=K4u4rvL1ix25wG4EPnwUiFmmo4K7q2d89aYLvEKkQkFiKSSoa308IBJXE0GqfDObjs DXHD9hoa65zrFcnoMQPridcyp5UDWtpizLbS1lAB+v9i0M3iwM4rfRGCLmml3LX0sPSJ yLvB7+8FNDxy8hM7CUPP16dEUNFabNje8y62kA3fV1vcmnc+P9W87K18V/RuGzv6qIMg TFQRtPd0VGSoYPgclcjHp38TCQpj5z5ROtw0lANc0BW9rZ5B6BixRMwTDiL391Mwnc4b 5Y5Q+eGGPa3zpODhoCBqVmjc2IwfoZpR4LeEq4/KgLBQ6MVpis2SdDcrYQN11TEoYKRX Em/w== X-Gm-Message-State: AOAM531JJnV9CsOai5XfLazrfSkpGz999iGmWZksIdgKddhv8xc8JsHV l53OOjUDVGdntlnUeT012GA2EA== X-Google-Smtp-Source: ABdhPJz01Umh6zLfuwwGUusXjOlrZ3VrH1wOZO/VqjtjXCKZvrmxg/RnbVEb76RMNUsymXy7cdAvng== X-Received: by 2002:a4a:94c3:: with SMTP id l3mr9789581ooi.12.1618859871144; Mon, 19 Apr 2021 12:17:51 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q9sm282031oig.7.2021.04.19.12.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 12:17:50 -0700 (PDT) Date: Mon, 19 Apr 2021 14:17:48 -0500 From: Bjorn Andersson To: AngeloGioacchino Del Regno , Manivannan Sadhasivam Cc: viresh.kumar@linaro.org, agross@kernel.org, rjw@rjwysocki.net, devicetree@vger.kernel.org, robh+dt@kernel.org, amit.kucheria@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org, jeffrey.l.hugo@gmail.com Subject: Re: [PATCH v4 4/7] dt-bindings: cpufreq: cpufreq-qcom-hw: Convert to YAML bindings Message-ID: <20210419191748.GS1538589@yoga> References: <20210119174557.227318-1-angelogioacchino.delregno@somainline.org> <20210119174557.227318-5-angelogioacchino.delregno@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210119174557.227318-5-angelogioacchino.delregno@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 19 Jan 11:45 CST 2021, AngeloGioacchino Del Regno wrote: [..] > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml > new file mode 100644 > index 000000000000..bc81b6203e27 > --- /dev/null > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml > @@ -0,0 +1,204 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/cpufreq/cpufreq-qcom-hw.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. CPUFREQ > + > +maintainers: > + - Manivannan Sadhasivam > + Mani, I presume you're still up for the maintainership of this binding? > +description: | > + > + CPUFREQ HW is a hardware engine used by some Qualcomm Technologies, Inc. (QTI) > + SoCs to manage frequency in hardware. It is capable of controlling frequency > + for multiple clusters. [..] > + > +required: > + - compatible > + - reg > + - reg-names This is optional in the .txt version and as such I would like you to make this required in a separate patch following the yaml conversion. Apart from that I think this looks good. > + - clocks > + - clock-names > + - '#freq-domain-cells' > + Regards, Bjorn