From: Yury Norov <yury.norov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
linux-doc@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Jonathan Corbet <corbet@lwn.net>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Palmer Dabbelt <palmerdabbelt@google.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Randy Dunlap <rdunlap@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/2] rcu/tree_plugin: don't handle the case of 'all' CPU range
Date: Tue, 20 Apr 2021 12:38:46 -0700 [thread overview]
Message-ID: <20210420193846.GB61766@yury-ThinkPad> (raw)
In-Reply-To: <YH6qgHH1RtBCHxEy@smile.fi.intel.com>
On Tue, Apr 20, 2021 at 01:18:40PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 19, 2021 at 05:01:31PM -0700, Yury Norov wrote:
> > The 'all' semantics is now supported by the bitmap_parselist() so we can
> > drop supporting it as a special case in RCU code. This patch does not
> > add any functional changes for existing users.
>
> > - if (!strcasecmp(str, "all")) /* legacy: use "0-N" instead */
>
> Perhaps move comment as well to new location.
I actually wanted to remove this comment. The reason is that 'all' is
verbose, clear and proven to be useful for at least RCU. In v2 I'll
mention it explicitly in commit comment.
next prev parent reply other threads:[~2021-04-20 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 0:01 [PATCH 0/2] bitmap_parselist: support 'all' semantics Yury Norov
2021-04-20 0:01 ` [PATCH 1/2] bitmap_parse: " Yury Norov
2021-04-20 10:17 ` Andy Shevchenko
2021-04-20 19:32 ` Yury Norov
2021-04-20 0:01 ` [PATCH 2/2] rcu/tree_plugin: don't handle the case of 'all' CPU range Yury Norov
2021-04-20 10:18 ` Andy Shevchenko
2021-04-20 19:38 ` Yury Norov [this message]
2021-04-20 10:19 ` [PATCH 0/2] bitmap_parselist: support 'all' semantics Andy Shevchenko
2021-04-21 3:13 [PATCH v2 " Yury Norov
2021-04-21 3:13 ` [PATCH 2/2] rcu/tree_plugin: don't handle the case of 'all' CPU range Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420193846.GB61766@yury-ThinkPad \
--to=yury.norov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mathieu.desnoyers@efficios.com \
--cc=palmerdabbelt@google.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).