From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF622C433B4 for ; Wed, 21 Apr 2021 13:07:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB9616145E for ; Wed, 21 Apr 2021 13:07:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240023AbhDUNI0 (ORCPT ); Wed, 21 Apr 2021 09:08:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:45702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240759AbhDUNGQ (ORCPT ); Wed, 21 Apr 2021 09:06:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E11761457; Wed, 21 Apr 2021 13:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010342; bh=juUxxHyTJNXY+DhWA+mtTWofbBqB/c0g4+Ki/KsCe38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eAXjs9Sk9BPSZnVBD30gz9H01sud8IxcsrLofdFT7IwwO7iwzuJeT1Zx1mijzT8aE adS6XWX1WPWtIxr+fOxUWccFKqNUvXznhoEm9Q8zfhCaCFBC/p9L8wus6U0sKZzSt7 R/Grm8+iNaoQ/3UiX9DZHKXXVa8nSCQp5aKWJ5DQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Kangjie Lu , Vaibhav Agarwal , Viresh Kumar Subject: [PATCH 100/190] Revert "staging: greybus: audio_manager: fix a missing check of ida_simple_get" Date: Wed, 21 Apr 2021 14:59:35 +0200 Message-Id: <20210421130105.1226686-101-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit b5af36e3e5aa074605a4d90a89dd8f714b30909b. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Kangjie Lu Cc: Vaibhav Agarwal Cc: Viresh Kumar Cc: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/audio_manager.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index 9a3f7c034ab4..7c7ca671876d 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -45,9 +45,6 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) int err; id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL); - if (id < 0) - return id; - err = gb_audio_manager_module_create(&module, manager_kset, id, desc); if (err) { -- 2.31.1