From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F2AC433B4 for ; Wed, 21 Apr 2021 13:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C31E261458 for ; Wed, 21 Apr 2021 13:05:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240938AbhDUNGO (ORCPT ); Wed, 21 Apr 2021 09:06:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:45538 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240743AbhDUNEz (ORCPT ); Wed, 21 Apr 2021 09:04:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 30A2F61455; Wed, 21 Apr 2021 13:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010261; bh=H4zDc2bG7JFX23RuEa/AT8o7M6KvUdWM7bHiUzRtuEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ukf+YFETYZprKWmFUloLIyXWXywvH7Cwq1TTXc6AiwLRtOLIa80zkN2Z1JG5NAoTH 1NpU20QXOGlNqKF9Ghlh4Cq4w4kDijSnMOedHvTWeRIQ77eppifRN6CG5PDpDCSlSQ 1UFEqeDcJLUMFQJYDG/MdVHRcdXLckRttNGJc7+k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Qiushi Wu , Cornelia Huck , Kirti Wankhede , Alex Williamson Subject: [PATCH 036/190] Revert "vfio/mdev: Fix reference count leak in add_mdev_supported_type" Date: Wed, 21 Apr 2021 14:58:31 +0200 Message-Id: <20210421130105.1226686-37-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit aa8ba13cae3134b8ef1c1b6879f66372531da738. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Qiushi Wu Cc: Cornelia Huck Cc: Kirti Wankhede Cc: Alex Williamson Signed-off-by: Greg Kroah-Hartman --- drivers/vfio/mdev/mdev_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c index 917fd84c1c6f..8ad14e5c02bf 100644 --- a/drivers/vfio/mdev/mdev_sysfs.c +++ b/drivers/vfio/mdev/mdev_sysfs.c @@ -110,7 +110,7 @@ static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent, "%s-%s", dev_driver_string(parent->dev), group->name); if (ret) { - kobject_put(&type->kobj); + kfree(type); return ERR_PTR(ret); } -- 2.31.1