From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Huacai Chen <chenhuacai@kernel.org>,
Huacai Chen <chenhuacai@loongson.cn>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-arch@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/math/test_div64: Fix error message formatting
Date: Wed, 21 Apr 2021 16:15:18 +0200 [thread overview]
Message-ID: <20210421141518.GA11331@alpha.franken.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2104211445290.44318@angie.orcam.me.uk>
On Wed, Apr 21, 2021 at 03:25:22PM +0200, Maciej W. Rozycki wrote:
> Align the expected result with one actually produced for easier visual
> comparison; this has to take into account what the format specifiers
> will actually produce rather than the characters they consist of. E.g.:
>
> test_div64: ERROR: 10000000ab275080 / 00000009 => 01c71c71da20d00e,00000002
> test_div64: ERROR: expected value => 0000000013045e47,00000001
>
> (with a failure induced by setting bit #60 of the divident).
>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> ---
> lib/math/test_div64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-04-21 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 13:25 [PATCH] lib/math/test_div64: Fix error message formatting Maciej W. Rozycki
2021-04-21 14:15 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421141518.GA11331@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).