From: Rob Herring <robh@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: gpio: Add devicetree binding for IDT 79RC3243x GPIO controller
Date: Wed, 21 Apr 2021 12:17:27 -0500 [thread overview]
Message-ID: <20210421171727.GA1310436@robh.at.kernel.org> (raw)
In-Reply-To: <20210421162026.41978-2-tsbogend@alpha.franken.de>
On Wed, Apr 21, 2021 at 06:20:26PM +0200, Thomas Bogendoerfer wrote:
> Add YAML devicetree binding for IDT 79RC3243x GPIO controller
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
> .../bindings/gpio/gpio-idt3243x.yaml | 73 +++++++++++++++++++
Use compatible string for filename.
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml b/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml
> new file mode 100644
> index 000000000000..346a57ef8298
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-idt3243x.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/gpio-idt3243x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IDT 79RC32434x GPIO controller
> +
> +maintainers:
> + - Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> +
> +properties:
> + compatible:
> + const: idt,3243x-gpio
What's the 'x'? Generally, we don't do wildcards for compatible strings.
> +
> + reg:
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: gpio
> + - const: pic
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + ngpios:
> + description:
> + Number of available gpios in a bank.
That's every 'ngpios'. Drop.
> + minimum: 1
> + maximum: 32
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - gpio-controller
> + - "#gpio-cells"
> + - ngpios
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpio0: interrupt-controller@50000 {
gpio@...
As generally it's primarily a GPIO controller and secondarily an
interrupt controller.
> + compatible = "idt,3243x-gpio";
> + reg = <0x50000 0x14>, <0x38030 0x0c>;
> + reg-names = "gpio", "pic";
> +
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + interrupt-parent = <&cpuintc>;
> + interrupts = <6>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + ngpios = <14>;
> + };
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-04-21 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 16:20 [PATCH v2 1/2] gpio: Add support for IDT 79RC3243x GPIO controller Thomas Bogendoerfer
2021-04-21 16:20 ` [PATCH v2 2/2] dt-bindings: gpio: Add devicetree binding " Thomas Bogendoerfer
2021-04-21 17:17 ` Rob Herring [this message]
2021-04-21 17:39 ` Thomas Bogendoerfer
2021-04-22 13:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421171727.GA1310436@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).