linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Mike Travis <mike.travis@hpe.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Borislav Petkov <bp@suse.de>,
	Dimitri Sivanich <dimitri.sivanich@hpe.com>,
	Steve Wahl <steve.wahl@hpe.com>
Subject: arch/x86/kernel/apic/x2apic_uv_x.c:106 early_get_pnodeid() warn: inconsistent indenting
Date: Wed, 21 Apr 2021 19:03:51 +0800	[thread overview]
Message-ID: <202104211946.vkuV39N1-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 5505 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1fe5501ba1abf2b7e78295df73675423bd6899a0
commit: 6c7794423a998478f6df0234d2dd5baa3ccbdb1d x86/platform/uv: Add UV5 direct references
date:   7 months ago
config: x86_64-randconfig-m001-20210421 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
arch/x86/kernel/apic/x2apic_uv_x.c:106 early_get_pnodeid() warn: inconsistent indenting

vim +106 arch/x86/kernel/apic/x2apic_uv_x.c

1b9b89e7f16333 arch/x86/kernel/genx2apic_uv_x.c   Yinghai Lu   2008-07-21   91  
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05   92  static void __init early_get_pnodeid(void)
27229ca63269c1 arch/x86/kernel/apic/x2apic_uv_x.c Jack Steiner 2009-04-17   93  {
d8850ba425d982 arch/x86/kernel/apic/x2apic_uv_x.c Jack Steiner 2010-11-30   94  	int pnode;
7a1110e861b266 arch/x86/kernel/apic/x2apic_uv_x.c Jack Steiner 2010-01-12   95  
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05   96  	uv_cpuid.m_skt = 0;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05   97  	if (UVH_RH10_GAM_ADDR_MAP_CONFIG) {
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05   98  		union uvh_rh10_gam_addr_map_config_u  m_n_config;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05   99  
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  100  		m_n_config.v = uv_early_read_mmr(UVH_RH10_GAM_ADDR_MAP_CONFIG);
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  101  		uv_cpuid.n_skt = m_n_config.s.n_skt;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  102  		uv_cpuid.nasid_shift = 0;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  103  	} else if (UVH_RH_GAM_ADDR_MAP_CONFIG) {
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  104  		union uvh_rh_gam_addr_map_config_u  m_n_config;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  105  
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05 @106  	m_n_config.v = uv_early_read_mmr(UVH_RH_GAM_ADDR_MAP_CONFIG);
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  107  		uv_cpuid.n_skt = m_n_config.s.n_skt;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  108  		if (is_uv(UV3))
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  109  			uv_cpuid.m_skt = m_n_config.s3.m_skt;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  110  		if (is_uv(UV2))
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  111  			uv_cpuid.m_skt = m_n_config.s2.m_skt;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  112  		uv_cpuid.nasid_shift = 1;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  113  	} else {
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  114  		unsigned long GAM_ADDR_MAP_CONFIG = 0;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  115  
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  116  		WARN(GAM_ADDR_MAP_CONFIG == 0,
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  117  			"UV: WARN: GAM_ADDR_MAP_CONFIG is not available\n");
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  118  		uv_cpuid.n_skt = 0;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  119  		uv_cpuid.nasid_shift = 0;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  120  	}
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  121  
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  122  	if (is_uv(UV4|UVY))
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  123  		uv_cpuid.gnode_shift = 2; /* min partition is 4 sockets */
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  124  
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  125  	uv_cpuid.pnode_mask = (1 << uv_cpuid.n_skt) - 1;
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  126  	pnode = (uv_node_id >> uv_cpuid.nasid_shift) & uv_cpuid.pnode_mask;
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  127  	uv_cpuid.gpa_shift = 46;	/* Default unless changed */
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  128  
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  129  	pr_info("UV: n_skt:%d pnmsk:%x pn:%x\n",
6c7794423a9984 arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  130  		uv_cpuid.n_skt, uv_cpuid.pnode_mask, pnode);
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  131  }
647128f1536efa arch/x86/kernel/apic/x2apic_uv_x.c Mike Travis  2020-10-05  132  

:::::: The code at line 106 was first introduced by commit
:::::: 647128f1536efacca7bedf189790d24b22f03cca x86/platform/uv: Update UV MMRs for UV5

:::::: TO: Mike Travis <mike.travis@hpe.com>
:::::: CC: Borislav Petkov <bp@suse.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32492 bytes --]

             reply	other threads:[~2021-04-21 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 11:03 kernel test robot [this message]
2021-04-22  1:38 ` arch/x86/kernel/apic/x2apic_uv_x.c:106 early_get_pnodeid() warn: inconsistent indenting Mike Travis
2021-04-22  9:06   ` Borislav Petkov
2021-04-22 21:50     ` Mike Travis
2021-04-22 21:56       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104211946.vkuV39N1-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bp@suse.de \
    --cc=dimitri.sivanich@hpe.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.travis@hpe.com \
    --cc=steve.wahl@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).